Feature/linkedin click uri updates #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+14
to
+19
| # - package: fivetran/linkedin | ||
| # version: [">=0.10.0", "<0.11.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_linkedin.git | ||
| revision: feature/click-uri-updates | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Will update before merge and release
fivetran-catfritz
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
@fivetran-joemarkiewicz One small changelog comment. I was able to run the package updates and see that the click_uri coalesce is working properly, and the click_uri_type is populated correctly. I also tested the partitioning and source_relation logic, and that is compiling correctly. LGTM!
CHANGELOG.md
Outdated
| ### tiktok_ads | ||
| - In the [July 2023 update](https://fivetran.com/docs/connectors/applications/tiktok-ads/changelog#july2023) for the `ADGROUP_HISTORY` table, the `age` column was renamed to `age_groups`. | ||
| - In the [July 2023 update](https://fivetran.com/docs/connectors/applications/tiktok-ads/changelog#july2023) for the `ADGROUP_HISTORY` table, the `age` column was renamed to `age_groups`. ([PR #127](https://github.com/fivetran/dbt_ad_reporting/pull/127)) | ||
| - Previously in `dbt_tiktok_source`, we coalesced these two columns in the `stg_tiktok_ads__ad_group_history` model to account for connectors using the old naming convention. However, due to inconsistent data types, we can no longer use this approach. | ||
| - As a result, the coalesced field has been removed in favor of the `age_groups` column. | ||
| - If necessary, you can populate historical data in the `age_groups` column by performing a resync of the `ADGROUP_HISTORY` table, since TikTok provides all data regardless of the previous sync state. | ||
| - For more details, see the [DECISIONLOG entry](https://github.com/fivetran/dbt_tiktok_ads_source/blob/main/DECISIONLOG.md). | ||
|
|
||
| # dbt_ad_reporting v1.10.0 |
There was a problem hiding this comment.
I think this meant to be part of v1.11.0
There was a problem hiding this comment.
Yup! It looks like this was leftover from the merge conflicts. Updated.
fivetran-joemarkiewicz
deleted the
feature/linkedin-click-uri-updates
branch
fivetran-joemarkiewicz
restored the
feature/linkedin-click-uri-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: dbt_linkedin Issue #35
This PR will result in the following new package version:
v1.11.0This will be a breaking change as a result of the upstream dbt_linkedin and dbt_linkedin_source updates.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
❗ Special Updates for Ad Reporting ❗
To reduce integration testing time, not all models should be enabled in the
run_models.shvars. Update the variables afterdbt runanddbt testto set:truetrue(if not already)falseDetailed Validation
Please share any and all of your validation steps:
Please see the upstream PRs for relevant validations:
Additionally, please see the passing validation tests below:
If you had to summarize this PR in an emoji, which would it be?
🔗