HolgerAusB ippen.media-1 adds 50+ new newspaper sites by fingerprint #928
Conversation
| # a) | ||
| # copy this file and name it for your domains e.g.: | ||
| # custom/hanauer.de.txt | ||
| # custom/ruhr24.de.txt |
There was a problem hiding this comment.
Looks like there can be a fingerprints from the html code.
/\<div\s*class=([\'"])id-SiteBEEPWrap([\'"])\>/i
That can be added over here: https://github.com/j0k3r/graby/blob/6ed01641205b7fbdea4ce9ba15a34989af9edc1a/src/Extractor/ContentExtractorConfig.php#L39
What do you think?
There was a problem hiding this comment.
will check that tomorrow. Thank you for looking into that
There was a problem hiding this comment.
this one is not working with fulltext-rss. As I wrote in #926 ftr seems to check only the <head> for matches, but your suggestion is within the <body>. And to get sure, I also used a shorter version just for testing:
'id-SiteBEEPWrap' => array('hostname'=>'fingerprint.ippen.media', 'head'=>true),
But still got "No fingerprint matches"
There was a problem hiding this comment.
@HolgerAusB We'll see if it's possible to add this to Full-Text RSS in the config file. It should be possible to use the body and not just the head, if not, we'll fix that in the next version.
There was a problem hiding this comment.
Sorry for the slow response. Haven't forgotten about this, just been very busy. I think we can merge this, as the config changes if/where they're needed have to happen separately anyway. What do you think @j0k3r @HolgerAusB
yes, of course. thank you Co-authored-by: Jérémy Benoist <[email protected]>
ATTENTION: this needs a change to the fingerprint-option in config.php or custom_config.php. Please check if this is possible. Lern more inside the file .ippen.media.txt
also see #926