Update datasource.go #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have a request with IF and LET statements get last result elements fiskaly#18
|
hello @ppaulweber are you check my change ? Regards |
ppaulweber
requested changes
Sep 25, 2024
There was a problem hiding this comment.
@josselinchevalay looks good so far, can you also provide in the provisioned dashboard an example use case of the let statement results fetching, see: https://github.com/fiskaly/grafana.surrealdb/blob/master/etc/provisioning/dashboards/Default/default.json
add new visualize elements to test LET statements
|
i add a table elements into default dashboard |
|
@ppaulweber any news about it ? |
|
I've just re-requested the review ... I'll take care of this ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a request with IF and LET statements get last result elements #18