Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return nil if component doesn't exist in lua script. #267

Merged
merged 1 commit into from
Nov 24, 2023
+9 −2
Merged

fix: return nil if component doesn't exist in lua script. #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions framework_crates/bones_scripting/src/lua/bindings/components.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,16 @@ pub fn metatable(ctx: Context) -> Table {
let ecsref = EcsRef {
data: EcsRefData::Component(ComponentRef { store, entity }),
path: default(),
};

// Return nil if the component is not present
if ecsref.borrow().schema_ref().is_err() {
stack.replace(ctx, Value::Nil);
return Ok(CallbackReturn::Return);
}
.into_value(ctx);
stack.push_front(ecsref);

let ecsref = ecsref.into_value(ctx);
stack.replace(ctx, ecsref);

Ok(CallbackReturn::Return)
}),
Expand Down
Loading