refactor: adjust charge rate based on claims if available

custom_components/openevse/__init__.py

@@ -42,6 +42,7 @@
     LIGHT_TYPES,
     MANAGER,
     PLATFORMS,
+    NUMBER_TYPES,
     SELECT_TYPES,
     SENSOR_TYPES,
     TIMEOUT_ERROR,
@@ -323,13 +324,16 @@ async def update_sensors(self) -> dict:
             raise UpdateFailed(error) from error
 
         self.parse_sensors()
+        await self.async_parse_sensors()
+        _LOGGER.debug("Coordinator data: %s", self._data)
         return self._data
 
     @callback
-    def websocket_update(self):
+    async def websocket_update(self):
         """Trigger processing updated websocket data."""
         _LOGGER.debug("Websocket update!")
         self.parse_sensors()
+        await self.async_parse_sensors()
         coordinator = self.hass.data[DOMAIN][self.config.entry_id][COORDINATOR]
         coordinator.async_set_updated_data(self._data)
 
@@ -373,6 +377,8 @@ def parse_sensors(self) -> None:
             data.update(_sensor)
         for select in SELECT_TYPES:  # pylint: disable=consider-using-dict-items
             _sensor = {}
+            if SELECT_TYPES[select].is_async_value:
+                continue
             try:
                 sensor_property = SELECT_TYPES[select].key
                 # Data can be sent as boolean or as 1/0
@@ -389,6 +395,26 @@ def parse_sensors(self) -> None:
                     select,
                 )
             data.update(_sensor)
+        for number in NUMBER_TYPES:  # pylint: disable=consider-using-dict-items
+            _sensor = {}
+            if NUMBER_TYPES[number].is_async_value:
+                continue
+            try:
+                sensor_property = NUMBER_TYPES[number].key
+                # Data can be sent as boolean or as 1/0
+                _sensor[number] = getattr(self._manager, sensor_property)
+                _LOGGER.debug(
+                    "number: %s sensor_property: %s value %s",
+                    number,
+                    sensor_property,
+                    _sensor[number],
+                )
+            except (ValueError, KeyError):
+                _LOGGER.info(
+                    "Could not update status for %s",
+                    number,
+                )
+            data.update(_sensor)            
         for light in LIGHT_TYPES:  # pylint: disable=consider-using-dict-items
             _sensor = {}
             try:
@@ -397,7 +423,7 @@ def parse_sensors(self) -> None:
                 _sensor[light] = getattr(self._manager, sensor_property)
                 _LOGGER.debug(
                     "light: %s sensor_property: %s value %s",
-                    select,
+                    light,
                     sensor_property,
                     _sensor[light],
                 )
@@ -408,7 +434,55 @@ def parse_sensors(self) -> None:
                 )
             data.update(_sensor)
         _LOGGER.debug("DEBUG: %s", data)
-        self._data = data
+        self._data.update(data)
+
+    async def async_parse_sensors(self) -> None:
+        """Parse updated sensor data using async."""
+        data = {}
+        for select in SELECT_TYPES:  # pylint: disable=consider-using-dict-items
+            _sensor = {}
+            if not SELECT_TYPES[select].is_async_value:
+                continue
+            try:
+                sensor_property = SELECT_TYPES[select].key
+                sensor_value = SELECT_TYPES[select].value
+                # Data can be sent as boolean or as 1/0
+                _sensor[select] = await getattr(self._manager, sensor_value)
+                _LOGGER.debug(
+                    "select: %s sensor_property: %s value %s",
+                    select,
+                    sensor_property,
+                    _sensor[select],
+                )
+            except (ValueError, KeyError):
+                _LOGGER.info(
+                    "Could not update status for %s",
+                    select,
+                )
+            data.update(_sensor)
+        for number in NUMBER_TYPES:  # pylint: disable=consider-using-dict-items
+            _sensor = {}
+            if not NUMBER_TYPES[number].is_async_value:
+                continue
+            try:
+                sensor_property = NUMBER_TYPES[number].key
+                sensor_value = NUMBER_TYPES[number].value
+                # Data can be sent as boolean or as 1/0
+                _sensor[number] = await getattr(self._manager, sensor_value)
+                _LOGGER.debug(
+                    "number: %s sensor_property: %s value %s",
+                    number,
+                    sensor_property,
+                    _sensor[number],
+                )
+            except (ValueError, KeyError):
+                _LOGGER.info(
+                    "Could not update status for %s",
+                    number,
+                )
+            data.update(_sensor)            
+        _LOGGER.debug("DEBUG: %s", data)
+        self._data.update(data)
 
 
 async def send_command(handler, command) -> None:

custom_components/openevse/const.py

@@ -420,11 +420,13 @@
     # ),
     "max_current_soft": OpenEVSESelectEntityDescription(
         name="Charge Rate",
-        key="current_capacity",
+        key="max_current_soft",
         default_options=None,
         command="set_current",
         entity_category=EntityCategory.CONFIG,
         entity_registry_enabled_default=False,
+        is_async_value=True,
+        value="async_charge_current",
     ),
     "charge_mode": OpenEVSESelectEntityDescription(
         name="Divert Mode",
@@ -504,13 +506,15 @@
 NUMBER_TYPES: Final[dict[str, OpenEVSENumberEntityDescription]] = {
     "max_current_soft": OpenEVSENumberEntityDescription(
         name="Charge Rate",
-        key="current_capacity",
+        key="max_current_soft",
         default_options=None,
         command="set_current",
         entity_category=EntityCategory.CONFIG,
         native_unit_of_measurement=UnitOfElectricCurrent.AMPERE,
         device_class=NumberDeviceClass.CURRENT,
         mode=NumberMode.AUTO,
+        is_async_value=True,
+        value="async_charge_current",
     ),
 }
 

custom_components/openevse/entity.py

@@ -16,6 +16,8 @@ class OpenEVSESelectEntityDescription(SelectEntityDescription):
 
     command: str | None = None
     default_options: list | None = None
+    is_async_value: bool | None = False
+    value: int | None = None
 
 
 @dataclass
@@ -33,6 +35,8 @@ class OpenEVSENumberEntityDescription(NumberEntityDescription):
     default_options: list | None = None
     min: int | None = None
     max: int | None = None
+    is_async_value: bool | None = False
+    value: int | None = None
 
 
 @dataclass

custom_components/openevse/manifest.json

@@ -9,7 +9,7 @@
   "iot_class": "local_push",
   "issue_tracker": "https://github.com/firstof9/openevse/issues",
   "loggers": ["openevsehttp"],
-  "requirements": ["python-openevse-http==0.1.63"],
+  "requirements": ["python-openevse-http==0.1.65"],
   "version": "0.0.0-dev",
   "zeroconf": ["_openevse._tcp.local."]
 }

custom_components/openevse/number.py

@@ -11,7 +11,7 @@
 from homeassistant.helpers.update_coordinator import CoordinatorEntity
 
 from .const import CONF_NAME, COORDINATOR, DOMAIN, NUMBER_TYPES, MANAGER
-from .entity import OpenEVSESelectEntityDescription
+from .entity import OpenEVSENumberEntityDescription
 
 from . import (
     OpenEVSEManager,
@@ -48,7 +48,7 @@ def __init__(
         self,
         config_entry: ConfigEntry,
         coordinator: OpenEVSEUpdateCoordinator,
-        description: OpenEVSESelectEntityDescription,
+        description: OpenEVSENumberEntityDescription,
         manager: OpenEVSEManager,
     ) -> None:
         """Initialize a ZwaveNumberEntity entity."""
@@ -62,6 +62,7 @@ def __init__(
         self._command = description.command
         self._min = description.min
         self._max = description.max
+        self._value = description.value
         self._manager = manager
         # Entity class attributes
         self._attr_name = f"{config_entry.data[CONF_NAME]} {self._name}"
@@ -78,6 +79,17 @@ def device_info(self):
         }
         return info
 
+    @property
+    def available(self) -> bool:
+        """Return if entity is available."""
+        data = self.coordinator.data
+        attributes = ("charge_mode", "divert_active")
+        if set(attributes).issubset(data.keys()) and self._type == "max_current_soft":
+            if data["divert_active"] and data["charge_mode"] == "eco":
+                _LOGGER.debug("Disabling %s due to PV Divert being active.", self._attr_name)
+                return False
+        return self.coordinator.last_update_success
+
     @property
     def native_min_value(self) -> float:
         """Return the minimum value."""
@@ -94,9 +106,10 @@ def native_max_value(self) -> float:
     def native_value(self) -> float | None:
         """Return the entity value."""
         data = self.coordinator.data
+        value = None
         if self._type in data and data is not None:
             value = data[self._type]
-            _LOGGER.debug("Select [%s] updated value: %s", self._type, value)
+        _LOGGER.debug("Number [%s] updated value: %s", self._type, value)
         return None if value is None else float(value)
 
     @property

custom_components/openevse/select.py

@@ -104,13 +104,17 @@ async def async_select_option(self, option: Any) -> None:
     @property
     def available(self) -> bool:
         """Return if entity is available."""
-        if self._type not in self.coordinator.data:
-            return False
+        data = self.coordinator.data
+        attributes = ("charge_mode", "divert_active")
+        if set(attributes).issubset(data.keys()) and self._type == "max_current_soft":
+            if data["divert_active"] and data["charge_mode"] == "eco":
+                _LOGGER.debug("Disabling %s due to PV Divert being active.", self._attr_name)
+                return False
         return self.coordinator.last_update_success
 
     def get_options(self) -> list[str]:
         """Return a set of selectable options."""
-        if self._type == "current_capacity":
+        if self._type == "max_current_soft":
             amps_min = self.coordinator.data["min_amps"]
             amps_max = self.coordinator.data["max_amps"] + 1
             # pylint: disable-next=consider-using-generator

requirements.txt

@@ -1 +1 @@
-python-openevse-http==0.1.63
+python-openevse-http==0.1.65

tests/conftest.py

@@ -19,6 +19,8 @@
 TEST_URL_STATUS = "http://openevse.test.tld/status"
 TEST_URL_CONFIG = "http://openevse.test.tld/config"
 TEST_URL_OVERRIDE = "http://openevse.test.tld/override"
+TEST_URL_CLAIMS = "http://openevse.test.tld/claims"
+TEST_URL_CLAIMS_TARGET = "http://openevse.test.tld/claims/target"
 TEST_URL_RAPI = "http://openevse.test.tld/r"
 TEST_URL_WS = "ws://openevse.test.tld/ws"
 TEST_TLD = "openevse.test.tld"
@@ -112,6 +114,12 @@ def test_charger(mock_aioclient):
         body='{ "msg": "OK" }',
         repeat=True,
     )
+    mock_aioclient.get(
+        TEST_URL_CLAIMS_TARGET,
+        status=200,
+        body='{"properties":{"state":"disabled","charge_current":28,"max_current":23,"auto_release":false},"claims":{"state":65540,"charge_current":65537,"max_current":65548}}',
+        repeat=True,
+    )    
     return main.OpenEVSE(TEST_TLD)
 
 
@@ -142,6 +150,12 @@ def test_charger_bad_serial(mock_aioclient):
         body=load_fixture("github.json"),
         repeat=True,
     )
+    mock_aioclient.get(
+        TEST_URL_CLAIMS_TARGET,
+        status=200,
+        body='{"properties":{"state":"disabled","charge_current":28,"max_current":23,"auto_release":false},"claims":{"state":65540,"charge_current":65537,"max_current":65548}}',
+        repeat=True,
+    )        
     return main.OpenEVSE(TEST_TLD)
 
 
@@ -177,6 +191,12 @@ def test_charger_bad_post(mock_aioclient):
         body=load_fixture("github.json"),
         repeat=True,
     )
+    mock_aioclient.get(
+        TEST_URL_CLAIMS_TARGET,
+        status=200,
+        body='{"properties":{"state":"disabled","charge_current":28,"max_current":23,"auto_release":false},"claims":{"state":65540,"charge_current":65537,"max_current":65548}}',
+        repeat=True,
+    )        
     return main.OpenEVSE(TEST_TLD)