Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rexi updated #423

Merged
merged 63 commits into from
Dec 17, 2024
Merged

Rexi updated #423

merged 63 commits into from
Dec 17, 2024

Conversation

jshipton
Copy link
Contributor

@jshipton jshipton commented Aug 15, 2023 •
edited
Loading

This contains code to compute the exponential of the linear operator defined by linearising an equation.

The code is tested for shallow water and compressible Boussinesq and there are also some tests for the REXI approximation.

jshipton and others added 13 commits August 15, 2023 14:33
@jshipton
rexi implementation
4a21a43
@jshipton
test for rexi
da360ed
@nhartney
update logging and time stepper
4a66c1a
@nhartney
put all REXI parameters in one class called RexiParameters
f5598b5
@nhartney
test for steps of the REXI approximation
b491443
@jshipton
fix rexi to work with recent replacement changes and replace .split()…
c8d9d39 
… with .subfunctions
@jshipton
Merge branch 'rexi_updated' of https://github.com/firedrakeproject/gusto
7fd711c 
 into rexi_updated
@jshipton
fix lint
78bbef6
@jshipton
fix lint for one of the test files
d9448ce
@nhartney
test for REXI using linear shallow water waves on the plane scenario
b38192f
@nhartney
test_linear_sw.py does the linear sw wave test with REXI and compares…
916613d 
… the output to a known checkpointed answer
@jshipton
fix firedrake split warning
eae9430
@jshipton
Merge branch 'rexi_updated' of https://github.com/firedrakeproject/gusto
9c2aee2 
 into rexi_updated
jshipton
jshipton commented Aug 17, 2023
View reviewed changes
Copy link
Contributor Author

@jshipton jshipton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhartney could you update the checkpoint data file to contain known correct output from REXI so that we can then make the test tolerances smaller? Thanks!

jshipton added 16 commits March 20, 2024 13:49
@jshipton
remove fml
9f24f14
@jshipton
fix definition of NullTerm
29cf593
@jshipton
argh lint!
8a935c7
@jshipton
still failing
0be451e
@jshipton
allow transporting velocity to be indexed
759c673
@jshipton
Merge branch 'boussinesq_compressible_switch' of https://github.com/f…
15b53d4 
…iredrakeproject/gusto into rexi_updated
@jshipton
some hacking for linear boussinesq equations
f51aefa
@jshipton
Merge branch 'main' of https://github.com/firedrakeproject/gusto into…
98769f4 
… rexi_updated
@jshipton
fix to default linearisation for Boussinesq
abe6229
@jshipton
Merge branch 'main' of https://github.com/firedrakeproject/gusto into…
9fd4f33 
… rexi_updated
@jshipton
start of compressible boussinesq test for rexi
91fc87f
@jshipton
fix lint and test description
d7de321
@jshipton
Merge branch 'main' of https://github.com/firedrakeproject/gusto into…
0f1d1f1 
… rexi_updated
@jshipton
File -> VTKFile
5772d98
@jshipton
improve docstring for rexi
e558533
@jshipton
update kgo file for rexi shallow water test
03d6746
JHopeCollins and others added 16 commits July 22, 2024 15:47
@JHopeCollins
rexi - only allreduce the real components
e5a9ef7
@JHopeCollins
rexi - use cpx for accumulating the sum
e3d4e78
@JHopeCollins
rexi - use cpx.DirichletBC
c1a7484
@JHopeCollins
rexi - use cpx.split
c5c827f
@JHopeCollins
rename rexi rhs for clarity
d574a37
@JHopeCollins
rexi - simplify building the complex system
c93dcd5
@JHopeCollins
rexi - calculate alpha*M and rhs with cpx. Still have to refactor tau*L
df86638
@JHopeCollins
rexi - calculate tau*L with cpx.
f8b1fd6
@JHopeCollins
rexi - allow choosing cpx implementation via init arg.
33e17fd
@JHopeCollins
rexi - add copy of complex_proxy to gusto.
bdb9272
@JHopeCollins
add complex_proxy tests
355dbe6
@jshipton
Merge pull request #520 from firedrakeproject/JHopeCollins/rexi_compl…
ac2f843 
…ex_proxy

Refactor REXI to use `complex-proxy` submodule
@jshipton
Merge branch 'main' of https://github.com/firedrakeproject/gusto into…
7b4540c 
… rexi_updated
@jshipton
fix import
1865563
@JHopeCollins
rexi - implement form_rhs using form_mass.
9937599
@jshipton
Merge branch 'main' into rexi_updated
31559b1
@tommbendall tommbendall added enhancement Involves adding a new capability research problem Involves new science, with possibly unknown outcome labels Aug 7, 2024
@tommbendall tommbendall marked this pull request as ready for review November 1, 2024 14:40
tommbendall
tommbendall previously approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with everything here -- we just need to merge in main and resolve conflicts

gusto/core/io.py
@@ -21,7 +21,7 @@ class GustoIOError(IOError):
pass


def pick_up_mesh(output, mesh_name):
def pick_up_mesh(output, mesh_name, comm=COMM_WORLD):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a brief chat about the addition of the comm argument here last week -- this makes sense to me now.

tommbendall
tommbendall approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jemma, exciting!

@tommbendall tommbendall merged commit 58617bc into main Dec 17, 2024
4 checks passed
@tommbendall tommbendall deleted the rexi_updated branch December 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommbendall tommbendall tommbendall approved these changes

Assignees
No one assigned
Labels
enhancement Involves adding a new capability research problem Involves new science, with possibly unknown outcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jshipton @tommbendall @nhartney @JDBetteridge @JHopeCollins