pyop3 #3318
Draft
pyop3 #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next step is to construct the PetscMats inside pyop3 from the sparsities. I have observed that explicitly tabulating the indices into a big sparsity array isn't actually helpful to do. We can just use the adjacency maps (that we can tabulate).
We now appear to be able to assemble a matrix, but we are not converging. Next step is to check the matrix values.
test_facets.py and DG advection test passing (in serial).
* WIP * All tests in test_constant passing * Apply suggestions from code review Co-authored-by: Jack Betteridge <[email protected]> * Matnest broke whilst I fixed constant * Mark tests Connor doesn't want to run * Skip some more tests * Fix test_zero_forms, except parallel * Re-enable tests in test_multiple_domains * Enable some tests, disable others --------- Co-authored-by: Connor Ward <[email protected]>
* Fix interpolators (change to pyop3 API) * Replace eager_zero with just zero * DO NOT MERGE pyop3 branch pointer * Update .github/workflows/build.yml --------- Co-authored-by: Jack Betteridge <[email protected]>
* pyop3: fix halo exchange --------- Co-authored-by: Connor Ward <[email protected]>
* Unskip interpolate tests * Add editables package (#3524) --------- Co-authored-by: India Marsden <[email protected]> Co-authored-by: Jack Betteridge <[email protected]>
I anticipate a number of failures, this commit is unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is my attempt to replace PyOP2 with pyop3 in Firedrake.
I now have reached a point where most of the "basics" of Firedrake are working, albeit very slowly. Some things that are known not to currently work include:
VertexOnlyMesh(point location templating is tricky)Please inspect the code at your own peril. The code is rife with commented out code blocks, TODO comments and bad variable names. It is also extremely slow. That said, I would be extremely happy to explain any of it if you have questions.
I plan to work on this as fast as I can over the next few months. Although there is a lot to do I think progress should be made fairly quickly.
Changes to other packages