Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flamenco: snapshot service #3197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

flamenco: snapshot service #3197

wants to merge 1 commit into from

Conversation

ibhatt-jumptrading
Copy link
Contributor

@ibhatt-jumptrading ibhatt-jumptrading commented Oct 23, 2024 •
edited
Loading

No description provided.

@ibhatt-jumptrading ibhatt-jumptrading force-pushed the snapshot_service branch 2 times, most recently from 445a7a1 to ad1dcd6 Compare December 17, 2024 15:24
@ibhatt-jumptrading ibhatt-jumptrading changed the title flamenco: snapshot service [WIP] flamenco: snapshot service Dec 17, 2024
topointon-jump
topointon-jump reviewed Dec 18, 2024
View reviewed changes
src/flamenco/snapshot/fd_snapshot_create.h Show resolved Hide resolved
src/app/fdctl/run/tiles/fd_replay.c Outdated Show resolved Hide resolved
src/app/fdctl/run/tiles/fd_replay.c Outdated Show resolved Hide resolved
src/app/fdctl/run/tiles/fd_replay.c Outdated Show resolved Hide resolved
src/flamenco/runtime/fd_hashes.c Outdated Show resolved Hide resolved
src/flamenco/snapshot/fd_snapshot_create.c Outdated Show resolved Hide resolved
src/flamenco/snapshot/fd_snapshot_create.c Outdated Show resolved Hide resolved
src/flamenco/types/fd_types.json Show resolved Hide resolved
src/util/archive/fd_tar.h Show resolved Hide resolved
topointon-jump
topointon-jump reviewed Dec 19, 2024
View reviewed changes
src/flamenco/snapshot/fd_snapshot_create.c Outdated Show resolved Hide resolved
src/flamenco/snapshot/fd_snapshot_create.c Outdated Show resolved Hide resolved
src/flamenco/snapshot/fd_snapshot_create.c Outdated Show resolved Hide resolved
src/flamenco/snapshot/fd_snapshot_create.c Outdated Show resolved Hide resolved
topointon-jump
topointon-jump previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📷 🔫

@ibhatt-jumptrading ibhatt-jumptrading marked this pull request as ready for review December 19, 2024 16:17
@ibhatt-jumptrading ibhatt-jumptrading force-pushed the snapshot_service branch 3 times, most recently from ee47a89 to 5a992d1 Compare December 19, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topointon-jump topointon-jump topointon-jump left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibhatt-jumptrading @topointon-jump