added quic support to fddev bench. Numerous QUIC fixes. #1655
Conversation
| ulong no_stream; | ||
|
|
||
| // vector receive members | ||
| struct mmsghdr rx_msgs[IO_VEC_CNT]; |
There was a problem hiding this comment.
Can we move all this QUIC stuff out to another file or like, fd_quic_client_t ? I feel like there could be a simple minimal interface which the bench tile can call without needing all of this stuff in its namespace.
There was a problem hiding this comment.
I suggest we do this in a follow up PR. fd_quic_test_client_t or something.
| uchar signature[ static 64 ], | ||
| uchar const payload[ static 130 ] ) { | ||
| fd_tls_test_sign_ctx_t * ctx = (fd_tls_test_sign_ctx_t *)_ctx; | ||
| fd_ed25519_sign( signature, payload, 130UL, ctx->public_key, ctx->private_key, ctx->sha512 ); |
There was a problem hiding this comment.
I'm not sure about signing on the benchs. The design here is that benchg is scalable and does signing, and benchs just sends on the socket (which is very expensive). If you are mixing those two things it makes the scaling story for the bench topology much more complicated.
There was a problem hiding this comment.
you think doing it in bencho is a better choice?
There was a problem hiding this comment.
you know, this signing only occurs during handshaking
There was a problem hiding this comment.
Oh, hmm. Then after that it's just TLS or whatever?
There was a problem hiding this comment.
@mmcgee-jump This signer interface is used by the TLS library to prove that it's in possession of the identity key. It only happens once per QUIC connection.
nbridge-jump
force-pushed
the
nbridge/bench-quic
branch
from
7fdf79c to
e13af38
Compare
bench code needs the following, but putting these into another PR:
quic_enable - hard coded flag to use quic rather than udp: should be configurable
only supports one connection. Each benchs should have a connection for each fd_quic tile
This PR should help us move forward with the demo