fddev: print genesis hash #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeng-jump
previously approved these changes
Apr 22, 2024
ripatel-fd
force-pushed
the
ripatel/print-genesis-hash
branch
2 times, most recently
from
fc6157a to
d86ec1b
Compare
|
This function already exists here: |
|
@alpeng-jump Would you like to take over and finish this PR? Let's deduplicate the logic to compute the shred version and genesis hash as Philip suggested. |
auto-merge was automatically disabled
April 22, 2024 18:16
Pull request was converted to draft
ptaffet-jump
force-pushed
the
ripatel/print-genesis-hash
branch
from
d86ec1b to
5866685
Compare
ptaffet-jump
approved these changes
Apr 22, 2024
|
Sorry was asleep then - thanks for picking up the changes @ripatel-fd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.