Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: add rust fuzz targets to highend fuzz artifacts #1063

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

marctrem
Copy link
Contributor

If the current fuzz build is highend, the publish_to_clusterfuzz.yml now builds the rust fuzz targets and places them next to the highend fuzz artifacts before the invocation to firedancer-io/clusterfuzz-action.

@marctrem marctrem requested a review from ripatel-fd December 14, 2023 21:38
@marctrem marctrem changed the title fuzz: add rust fuzz targets to highend fuzz artifact fuzz: add rust fuzz targets to highend fuzz artifacts Dec 14, 2023
@marctrem marctrem added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit f8610f9 Dec 14, 2023
9 checks passed
@marctrem marctrem deleted the marctrem/rust-fuzz branch December 14, 2023 21:40
@riptl
Copy link
Contributor

riptl commented Dec 15, 2023

Looks like this broke the ClusterFuzz integration for highend target on main.

@riptl
Copy link
Contributor

riptl commented Dec 15, 2023

@marctrem The ffi/rust fuzzers are somewhat flakey and are about to be replaced with a more stable approach. I don't think it's a good idea to build them in CI unless we have someone that can maintain them.

It would be nice to have this fuzzer in ClusterFuzz anyways. We previously discussed manually uploading the target to the cluster. Can we still do this or is it better to wait for the new target?

For now I sent a revert PR above to fix the build failure, so the other fuzz uploads work again.

Thanks for working on this!

@ripatel-fd ripatel-fd added this to the [M1.5] Frankendancer milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants