Fixing SSRC Typos and Minor Bugs #841
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Dec 20, 2024
| @@ -197,7 +197,7 @@ def get_float(self, key): | |||
| return self.get_value(key).as_float() | |||
|
|
|||
| def get_value(self, key): | |||
| if self._config_values[key]: | |||
| if key in self._config_values: | |||
| return self._config_values[key] | |||
There was a problem hiding this comment.
You might also be able to just do self._config_values.get(key, _Value('static')) here
| @@ -197,7 +197,7 @@ def get_float(self, key): | |||
| return self.get_value(key).as_float() | |||
|
|
|||
| def get_value(self, key): | |||
There was a problem hiding this comment.
Could we add type hints for all the functions where possible, please?
We are trying to add type hints to any new code. For example, see:
There was a problem hiding this comment.
Just noticed that you have added typehints to return types in most of the public functions. Thanks!
| predicate_fn: A function that takes an integer and returns a boolean. | ||
| version1: The first semantic version string. | ||
| version2: The second semantic version string. | ||
| predicate_fn: A function that takes an integer and returns a boolean. |
There was a problem hiding this comment.
Let's get a TW review on these docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.