Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firestore): Add Firestore Multi Database Support #818

Merged
merged 3 commits into from
Oct 24, 2024
Merged

feat(firestore): Add Firestore Multi Database Support #818

merged 3 commits into from
Oct 24, 2024

Conversation

jonathanedey
Copy link
Contributor

Fixes: #718

@jonathanedey jonathanedey added release-note release:stage Stage a release candidate labels Oct 22, 2024
@jonathanedey jonathanedey marked this pull request as ready for review October 23, 2024 14:39
lahirumaramba
lahirumaramba approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

firebase_admin/firestore.py Outdated Show resolved Hide resolved
firebase_admin/firestore.py Outdated Show resolved Hide resolved
egilmorez
egilmorez approved these changes Oct 23, 2024
View reviewed changes
Copy link

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But for a real answer on Python reference links, reach out to Mark or Juan Lara, thanks!

firebase_admin/firestore.py Show resolved Hide resolved
firebase_admin/firestore_async.py Outdated Show resolved Hide resolved
@jonathanedey jonathanedey merged commit 8727e91 into master Oct 24, 2024
12 checks passed
@lahirumaramba lahirumaramba deleted the je-firestore-multi-db branch October 24, 2024 14:18
@jonathanedey jonathanedey mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markarndt markarndt markarndt left review comments

@egilmorez egilmorez egilmorez approved these changes

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@lahirumaramba lahirumaramba

@egilmorez egilmorez

Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Add multiple Firestore support
4 participants
@jonathanedey @lahirumaramba @egilmorez @markarndt