fix(firestore-bigquery-export): serialize timestamps for partitions f…

…ield
firebase · Nov 13, 2023 · d878789 · d878789
1 parent b278992
commit d878789
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 8 deletions.
diff --git a/firestore-bigquery-export/CHANGELOG.md b/firestore-bigquery-export/CHANGELOG.md
@@ -1,3 +1,7 @@
+## Version 0.1.37
+
+fix - serialize timestamps to date string
+
 ## Version 0.1.36
 
 build - updated depenencies

diff --git a/firestore-bigquery-export/extension.yaml b/firestore-bigquery-export/extension.yaml
@@ -13,7 +13,7 @@
 # limitations under the License.
 
 name: firestore-bigquery-export
-version: 0.1.36
+version: 0.1.37
 specVersion: v1beta
 
 displayName: Stream Firestore to BigQuery

diff --git a/firestore-bigquery-export/firestore-bigquery-change-tracker/package.json b/firestore-bigquery-export/firestore-bigquery-change-tracker/package.json
@@ -5,7 +5,7 @@
     "url": "github.com/firebase/extensions.git",
     "directory": "firestore-bigquery-export/firestore-bigquery-change-tracker"
   },
-  "version": "1.1.27",
+  "version": "1.1.28",
   "description": "Core change-tracker library for Cloud Firestore Collection BigQuery Exports",
   "main": "./lib/index.js",
   "scripts": {

diff --git a/firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/index.ts b/firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/index.ts
@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import * as admin from "firebase-admin";
 import * as bigquery from "@google-cloud/bigquery";
 import { DocumentReference } from "firebase-admin/firestore";
 import * as traverse from "traverse";
@@ -155,6 +155,9 @@ export class FirestoreBigQueryEventHistoryTracker
         if (property.constructor.name === DocumentReference.name) {
           this.update(property.path);
         }
+        if (property instanceof admin.firestore.Timestamp) {
+          this.update(property.toDate());
+        }
       }
     });
 

diff --git a/firestore-bigquery-export/functions/package-lock.json b/firestore-bigquery-export/functions/package-lock.json
diff --git a/firestore-bigquery-export/functions/package.json b/firestore-bigquery-export/functions/package.json
@@ -13,7 +13,7 @@
   "author": "Jan Wyszynski <[email protected]>",
   "license": "Apache-2.0",
   "dependencies": {
-    "@firebaseextensions/firestore-bigquery-change-tracker": "^1.1.27",
+    "@firebaseextensions/firestore-bigquery-change-tracker": "^1.1.28",
     "@google-cloud/bigquery": "^4.7.0",
     "@types/chai": "^4.1.6",
     "@types/express-serve-static-core": "4.17.30",