Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 16 build error #1211

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Fix Xcode 16 build error #1211

merged 7 commits into from
Oct 15, 2024

Conversation

paulb777
Copy link
Member

Fix #1209

Recent versions of Xcode 16 give compilation errors for the FUIAuthDelegate Firebase 10 compatibility methods. This PR resolves the build issue by deleting those methods.

Firebase 10 users of FUIAuthDelegate should use a a FirebaseUI version earlier than 14.2.5.

@paulb777 paulb777 requested a review from morganchen12 October 15, 2024 17:59
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one requested change.

FirebaseAuthUI.podspec Show resolved Hide resolved
@paulb777
Copy link
Member Author

Removed Podfile.lock's so CI tests with latest acceptable dependencies

@paulb777 paulb777 merged commit be95f19 into main Oct 15, 2024
35 checks passed
@paulb777 paulb777 deleted the pb-drop-fb10 branch October 15, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous inference of Objective-C name for instance method when upgrading to FirebaseAuthUI 14.2.4
2 participants