Skip to content

Commit

Permalink
Add nodejs 16 to amazon linux
Browse files Browse the repository at this point in the history
  • Loading branch information
RicardoMDomingues committed Sep 23, 2024
1 parent c1a9ce4 commit a97ce98
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pr-unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,21 +68,21 @@ jobs:
- name: DEBUG search unit tests logs
run: find . -type f -iname "smb_unit_test*"
- name: Upload Unit test logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always() # This step runs regardless of the previous step results
with:
name: unit-test-logs-${{ matrix.os }}-${{ matrix.build.type }}
retention-days: 14
path: tools/testfiles/smb_unit_test*.log
- name: Upload test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always() # This step runs regardless of the previous step results
with:
name: test-results-${{ matrix.build.type == '' }}-${{ matrix.build.type }}
retention-days: 14
path: ${{ matrix.os }}/smb/test-results*.xml
- name: Upload Code Coverage
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: matrix.build.type =='LCov' && success() # This step runs regardless of the previous step results
with:
name: code-coverage-${{ matrix.os }}-${{ matrix.build.type }}
Expand Down
6 changes: 6 additions & 0 deletions docker/aws-linux/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,9 @@ RUN cd /tmp \
&& ./configure \
&& make -j5 \
&& make install

# Install Node 16 for running Github Actions as most recent node verions
# that would be added (mounterd) by Github Actions one that is
# is not compatible with GLIBC available on Amazon Linux 2 (Centos 7)
RUN curl -sL https://rpm.nodesource.com/setup_16.x | bash -
RUN yum -y install nodejs

0 comments on commit a97ce98

Please sign in to comment.