Only enqueue a sched job if the worker removed it #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reported in #50 that we have a race-condition with this scheduled enqueuer code. I think the issue was that I was _assuming_ that redis would coerce a 0 to false and a 1 to true, but I don't think that's really the case. (Still need to double check that). Better yet, we should add a new test to prove this. NOTE: I also updated the `n` reported by this method to only count the `n` if it actually enqueued a job. NOTE 2: I think it's best if we bring the enqueue batch size down from 100 to 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported in #50 that we have a race-condition with this scheduled enqueuer code. I think the issue was that I was assuming that redis would coerce a 0 to false and a 1 to true, but I don't think that's really the case. (Still need to double check that).
Better yet, we should add a new test to prove this.
NOTE: I also updated the
nreported by this method to only count thenif it actually enqueued a job.NOTE 2: I think it's best if we bring the enqueue batch size down from 100 to 10.