Add a yield to prevent Processor from hogging redis connections
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- When there are no sidekiq jobs available in redis, there are no `await`s between when `brpop`returns and when the next connection is acquired from the pool. This means tokio's task scheduler doesn't have a chance to switch to another task that's waiting for a connection. Solution -------- Add a `tokio::task::yield_now().await` in the case where there is no actual job to handle. This allows tokio's task scheduler to wake up a different task that's waiting for a connection. film42#43
film42
approved these changes
Apr 25, 2024
|
Released as version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When there are no sidekiq jobs available in redis, there are no
awaits between whenbrpopreturns and when the next connection is acquired from the pool. This means tokio's task scheduler doesn't have a chance to switch to another task that's waiting for a connection.Solution
Add a
tokio::task::yield_now().awaitin the case where there is no actual job to handle. This allows tokio's task scheduler to wake up a different task that's waiting for a connection.#43