Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tests: create issue on very expensive test failure #12277

Merged

Conversation

laurentsenta
Copy link
Contributor

@laurentsenta laurentsenta commented Jul 23, 2024

Related Issues

Contributes to #12136

Proposed Changes

  • When the test fails during a scheduled run (nightly job), create an issue / add a comment

Additional Info

Set as Draft and request @galargh pre-review for now,
we'll merge into the whole feature (ipdx-with-very-expensive-flag) and request the team's final review there.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@laurentsenta laurentsenta marked this pull request as draft July 23, 2024 08:36
@laurentsenta laurentsenta force-pushed the ipdx-create-issue-on-failure branch 2 times, most recently from f0f1c2b to a4a4e3d Compare July 23, 2024 09:46
@laurentsenta laurentsenta force-pushed the ipdx-with-very-expensive-flag branch from cb5416c to ed60445 Compare July 23, 2024 09:50
@laurentsenta
Copy link
Contributor Author

test run https://github.com/laurentsenta/lotus/actions/workflows/test.yml (fails on purpose)
result: laurentsenta#1

@laurentsenta laurentsenta marked this pull request as ready for review July 23, 2024 12:39
@laurentsenta laurentsenta merged commit dd43d30 into ipdx-with-very-expensive-flag Jul 23, 2024
76 checks passed
@laurentsenta laurentsenta deleted the ipdx-create-issue-on-failure branch July 23, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants