-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: niporep: e2e testing #12105
Merged
Merged
test: niporep: e2e testing #12105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
All checks have passed |
rvagg
force-pushed
the
rvagg/niporep
branch
4 times, most recently
from
June 19, 2024 06:29
394345f
to
20b7dab
Compare
rvagg
force-pushed
the
rvagg/niporep
branch
2 times, most recently
from
June 21, 2024 06:53
2c223d2
to
e453875
Compare
rvagg
force-pushed
the
rvagg/niporep
branch
4 times, most recently
from
June 25, 2024 04:12
174c385
to
c91b771
Compare
This was referenced Jun 25, 2024
|
Ready for review |
aarshkshah1992
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get the test for >1 sectors in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #12045
Initial form here has e2e onboarding of a single sector. Need to add:
sector-activated
event(s) (NOTE: needs fixing in builtin-actors: https://github.com/filecoin-project/builtin-actors/pull/1537/files/#r1648458930)This branch uses filecoin-project/builtin-actors#1537 for the actors bundle, but it also has filecoin-project/builtin-actors#1553 applied on top of it because otherwise preseals don't onboard and we can't get the chain started. It also has filecoin-project/filecoin-ffi#460 applied for filecoin-ffi because we need
verify-signature
.