Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential race when reading incomingErr #125

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 7, 2025

Reported by @parthshah1, discovered via Antithesis. A client is able to get itself into a state where there's a race in accessing incomingErr, so we'll lock it just to be safe.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@9a16432). Learn more about missing BASE report.

Files with missing lines Patch % Lines
websocket.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #125   +/-   ##
=========================================
  Coverage          ?   71.49%           
=========================================
  Files             ?       12           
  Lines             ?     1968           
  Branches          ?        0           
=========================================
  Hits              ?     1407           
  Misses            ?      460           
  Partials          ?      101           
Files with missing lines Coverage Δ
websocket.go 75.30% <75.00%> (ø)

@rvagg rvagg requested review from magik6k and Stebalien January 7, 2025 23:52
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like there should be a better way but this is definitely the safest approach.

@Stebalien Stebalien merged commit bd48140 into master Jan 8, 2025
7 checks passed
@Stebalien Stebalien deleted the rvagg/sync-err branch January 8, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants