Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update safer-ffi #485

Merged
merged 3 commits into from
Nov 7, 2024
Merged

chore: update safer-ffi #485

merged 3 commits into from
Nov 7, 2024

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien
Copy link
Member Author

On-top-of #484.

@cryptonemo
Copy link
Contributor

First thought is to check for memory leaks, as the valgrind command has been removed from CI, but seems reasonable otherwise

@Stebalien
Copy link
Member Author

First thought is to check for memory leaks, as the valgrind command has been removed from CI, but seems reasonable otherwise

Looks like I'm going to need a container for that. Valgrind doesn't work with znver4 optimized distributions.

@BigLep BigLep mentioned this pull request Sep 17, 2024
Closed
3 tasks
Base automatically changed from steb/update-fvm to master November 7, 2024 03:40
@Stebalien Stebalien requested a review from rvagg November 7, 2024 03:57
@Stebalien Stebalien merged commit f2809a2 into master Nov 7, 2024
5 checks passed
@Stebalien Stebalien deleted the steb/update-deps branch November 7, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

@cryptonemo cryptonemo Awaiting requested review from cryptonemo

@vmx vmx Awaiting requested review from vmx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stebalien @cryptonemo @rvagg