Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate Carbon Month Overflow Bug on 31st of a month #14678

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Mitigate Carbon Month Overflow Bug on 31st of a month #14678

merged 1 commit into from
Oct 31, 2024

Conversation

PascaleBeier
Copy link
Contributor

@PascaleBeier PascaleBeier commented Oct 31, 2024 •
edited
Loading

Description

On the 31st of each month, the month selector for for the month filter breaks. The months retrieved in getMonths() will output:

January
March
March
May
May
July
July
August
October
October
December
December

To mitigate this, we set the day to the first day of the month.

Related Carbon Issues: briannesbitt/Carbon#3097, briannesbitt/Carbon#2317

Visual changes

none

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Oct 31, 2024
@danharrin danharrin added this to the v3 milestone Oct 31, 2024
@danharrin danharrin merged commit 5aba3dc into filamentphp:3.x Oct 31, 2024
1 check passed
@danharrin
Copy link
Member

Cheers, this is not an easy bug to reproduce every day is it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@PascaleBeier @danharrin