Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hint for reviewer:
This code works right now. The next topic is to decide where to include it (as part of our lib or as a demo implementation)
APDU fragmenter: https://github.com/fidesmo/apdu-over-ble-android/blob/descriptor-fix/app/src/main/java/com/fidesmo/ble/client/apdu/SimpleApduFragmenter.java . Just to fragment and defragment packets at APDU level ( a packet could contains more than one apdu)
Custom defragmenter: https://github.com/fidesmo/apdu-over-ble-android/tree/descriptor-fix/app/src/main/java/com/fidesmo/ble/client/apdu (directory, check files starting with Custom)
In Android, BLE reads or writes data in small chunks and sometimes this chunk size doesn't fit the MTU defined. That's why an extra logic is needed to start to read a real packet and to completely read it: https://github.com/fidesmo/apdu-over-ble-android/blob/descriptor-fix/app/src/main/java/com/fidesmo/ble/client/BlePeripheralService.java#L251-L255
or in case of read request:
https://github.com/fidesmo/apdu-over-ble-android/blob/descriptor-fix/app/src/main/java/com/fidesmo/ble/client/BlePeripheralService.java#L223-L231