Enumeration metadata #101
Open
Enumeration metadata #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopry
force-pushed
the
enumeration_metadata
branch
from
4d59063 to
3a77785
Compare
dopry
force-pushed
the
enumeration_metadata
branch
from
3a77785 to
b2092f0
Compare
|
@fh1ch, I wanted to check in on the direction of this PR. Should I update it for the current codebase, or do you prefer another approach? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a metadata structure for all of the enumerations and removes metadata from enumerations themselves. This could be a breaking change for any consumers depending on that data.