Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: option to override the hostname #65

Closed
AiyionPrime opened this issue Feb 14, 2021 · 5 comments · Fixed by #63
Closed

feature: option to override the hostname #65

AiyionPrime opened this issue Feb 14, 2021 · 5 comments · Fixed by #63

Comments

@AiyionPrime
Copy link
Contributor

btw, is there an option to override the hostname?

I don't think so, but with the config file it should be easilier possible to add such an option, since their is to need to add another argc. 😄

Originally posted by @herbetom in #60 (comment)

This could improve usability on cheap VPS hosts, where hostnames get changed on a regular basis by the hoster.

@herbetom
Copy link
Contributor

I did something which just needs another solution for the float conversion: https://github.com/ffnord/mesh-announce/pull/63/files

@AiyionPrime
Copy link
Contributor Author

Looks very promising, another solution differently like what?

@herbetom
Copy link
Contributor

IIRC float and the fallback to None are not really compatible or something along those lines.

@AiyionPrime
Copy link
Contributor Author

Not tested this, but the only thing irritating about this is the rather unsafe conversion to float; but as it does this only with localconfig values, it should not be a huge problem, I think.

@AiyionPrime
Copy link
Contributor Author

Just clarify; his code works fine and would resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants