Fix FontAwesome SSR error #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Use FontAwesomeIconClient everywhere * Make icon optional * Use FontAwesomeClient in the sidebar
* Extract bg image/gradient into a separate fixed positioned div * Install @types/react-dom * Implement BgImageGradient * Don't use createPortal in BgImageGradient * Remove @types/react-dom
kafkas
force-pushed
the
ajiang/ssr_fix-fontawesome-ssr
branch
from
701e411 to
21b0fe9
Compare
|
@kafkas once we get a preview url with https://vellum-staging.docs.dev.buildwithfern.com/prompts/prompt-template-syntax and confirm it works, this is g2g |
dsinghvi
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Use the Fern-generated `AlgoliaRecord` type * Put each service into its own dir * Rename SearchRecord to AlgoliaSearchRecord * Replace deleteIndex() with clearIndexRecords() to prevent crash * Make sure `algoliaIndex` takes the value of fern domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used solution suggested in the relevant issue.