Rationalise plugin install prompts #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
reviewed
Apr 2, 2024
lann
reviewed
Apr 2, 2024
src/commands/external.rs
Outdated
| plugin.name() | ||
| ); | ||
| let prompt = format!( | ||
| "Would you like to install the '{}' with {} license from {}, and run it now?", |
There was a problem hiding this comment.
Should this read
Would you like to install the 'kube' plugin ...
?
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
plugin-prompt-shenanigans
branch
from
78904c4 to
0e11faf
Compare
lann
approved these changes
Apr 2, 2024
fibonacci1729
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apropos of #2368