Fix Windows not copying globs or directories #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
reviewed
Dec 12, 2023
itowlson
force-pushed
the
fix-windows-asset-globs
branch
2 times, most recently
from
62e8454 to
3de6b3e
Compare
rylev
previously requested changes
Dec 12, 2023
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
fix-windows-asset-globs
branch
from
3de6b3e to
9ad44b9
Compare
|
@rylev This is still blocked - I would like to get it into 2.1 if we can - do you still have concerns? |
vdice
approved these changes
Dec 13, 2023
itowlson
dismissed
rylev’s stale review
Comments added; if the comments need to be refined that can be done in a follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2111,
An alternative approach would be to remove the UNC prefix as mentioned in rust-lang/glob#132, which I can implement if people prefer.