Fix Windows error with HTTP components #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
force-pushed
the
fix-windows-invalid-cache-path
branch
from
09ec923 to
24d8a43
Compare
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
fix-windows-invalid-cache-path
branch
from
24d8a43 to
3ff7a4c
Compare
vdice
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2112.
The proposed fix is, on Windows, to save scheme-prefixed digests using an underscore separator, so a digest of
sha256:1234becomes a file name ofsha256_1234. Mac and Linux would not be affected.That said, there seems to be an oddity in the registry cache where some entries have the prefix and others don't - I think HTTP-downloaded components have the prefix and files from OCI don't? It would be nicer to change it to remove the prefix before saving HTTP-downloaded components. But that ended up involving more invasive changes to the download verifier, so I backed it out as being higher risk. I can explore it if people have a strong preference.