Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken template #1948

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix broken template #1948

merged 1 commit into from
Oct 25, 2023

Conversation

fibonacci1729
Copy link
Contributor

The http-rust template appears to have been broken by #1939. This PR updates the templates to use the new headers API.

templates/http-rust/content/src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: Brian H <[email protected]>
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for picking this up Brian!

@vdice vdice merged commit 94109b5 into fermyon:main Oct 25, 2023
8 of 9 checks passed
@@ -1,10 +1,10 @@
use spin_sdk::http::{IntoResponse, Request};
use spin_sdk::http::{HeaderValue, IntoResponse, Request};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new import necessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rylev no, we exterminated it in #1956

@fibonacci1729 fibonacci1729 deleted the fix-templates branch October 26, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants