core: Replace epoch deadline with yield #1684
Open
+50
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
commented
Aug 9, 2023
| /// details of the system's thread scheduler. | ||
| /// | ||
| /// See [`wasmtime::Store::set_epoch_deadline`](https://docs.rs/wasmtime/latest/wasmtime/struct.Store.html#method.set_epoch_deadline). | ||
| pub fn set_deadline(&mut self, deadline: Instant) { |
There was a problem hiding this comment.
Based on some searching I'm reasonably confident that this method isn't being used anywhere (public).
lann
commented
Aug 9, 2023
crates/core/src/lib.rs
Outdated
| @@ -37,7 +37,7 @@ pub use io::OutputBuffer; | |||
| pub use store::{Store, StoreBuilder, Wasi, WasiVersion}; | |||
|
|
|||
| /// The default [`EngineBuilder::epoch_tick_interval`]. | |||
| pub const DEFAULT_EPOCH_TICK_INTERVAL: Duration = Duration::from_millis(10); | |||
| pub const DEFAULT_EPOCH_TICK_INTERVAL: Duration = Duration::from_micros(100); | |||
There was a problem hiding this comment.
This arbitrarily updates the original arbitrary value, which "felt too slow" to me. 🤷
rylev
reviewed
Aug 9, 2023
|
@lann what's the state of this? I thought this had already been merged. |
|
Uhh I think I lost track of this back when e2e tests were broken for a while. Will refresh. |
lann
force-pushed
the
yield-interval
branch
from
7d907df to
7bae4a1
Compare
|
@lann did this once again go stale? |
|
Yep, but it could still be reviewed and then I could just merge it after the next rebase 🙂 |
With async yielding, instance execution can be implemented by dropping the async call future, with e.g. tokio::time::timeout. Signed-off-by: Lann Martin <[email protected]>
|
Sorry I'm a year and a half late on this; is it still relevant? |
|
Oof I'll have to set a reminder to come back and check in the new year 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With async yielding, instance execution can be implemented by dropping the async call future, with e.g. tokio::time::timeout.