Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for constant values #1835

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robertadkins
Copy link

Closes #1834

See the issue above for a description of a usecase where support for the const keyword is useful. Updated the snapshot tests to verify correct output.

@robertadkins robertadkins marked this pull request as ready for review October 14, 2023 00:35
@robertadkins
Copy link
Author

Since const was added in OpenAPI v3.1 (see discussion in #1834), updating this PR to only modify the v3 parsing and tests.

@mrlubos
Copy link
Collaborator

mrlubos commented Jan 28, 2024

@robertadkins we've decided to merge this pull request in our fork, thanks for this feature!

@kovalewvladimir
Copy link

@robertadkins we've decided to merge this pull request in our fork, thanks for this feature!

Thank you. It really works in the fork.

@mrlubos
Copy link
Collaborator

mrlubos commented Feb 21, 2024

@kovalewvladimir are there any other issues you're running into with this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for const keyword
3 participants