Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updpatch: fceux 2.6.6-3 #4265

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

Cryolitia
Copy link
Contributor

@Cryolitia Cryolitia commented Nov 12, 2024

  1. The x265 updates its API in 4.0, and the new API breaks the compatibility
    https://bitbucket.org/multicoreware/x265_git/commits/c69c113960834400545bc4bce2830ff51dcb86b3
  2. Arch Linux Package add a patch to pass compile but it's wrong and incomplete, which breaks over riscv64 build but not x86_64
    https://gitlab.archlinux.org/archlinux/packaging/packages/fceux/-/commit/617d6299d83ad54c105c457f151ee340a6c71de8
  3. The homebrew's opened a PR on fceux but also wrong and no maintainer response it
    chore: update AviRecord to comply with updated x265 API TASEmulators/fceux#766
  4. The VLC implement the compatibility with the new API
    https://code.videolan.org/videolan/vlc/-/merge_requests/6167
  5. I write a patch with my personal understanding with VLC's code, where the patch in the PR is from
    Cryolitia-Forks/fceux@7fad5b2

Upstreamed: https://gitlab.archlinux.org/archlinux/packaging/packages/fceux/-/merge_requests/1

Currently, I suggest to not to upstream to fceux itself. Not only because that I would like to waiting for upstream discussing it, maybe including increasing the efficiency by making use of the new API instead of simply handle it, but also the x265's said that just in the original commit session:

Hi, we are working on preserving the old API(x265_encoder_encode) and we shall be making a minor release (v4.1) with those changes shortly.

1. The x265 updates its API in 4.0, and the new API breaks the compatibility \
    https://bitbucket.org/multicoreware/x265_git/commits/c69c113960834400545bc4bce2830ff51dcb86b3
3. Arch Linux Package add a patch to pass compile but it's wrong and incomplete, which breaks over riscv64 build but not x86_64 \
    https://gitlab.archlinux.org/archlinux/packaging/packages/fceux/-/commit/617d6299d83ad54c105c457f151ee340a6c71de8
5. The homebrew's opened a PR on fceux but also wrong and no maintainer response it \
    TASEmulators/fceux#766
7. The VLC implement the compatibility with the new API \
    https://code.videolan.org/videolan/vlc/-/merge_requests/6167
9. I write a patch with my personal understanding with VLC's code, where the patch in the PR is from \
    Cryolitia-Forks/fceux@7fad5b2

Upstreamed: https://gitlab.archlinux.org/archlinux/packaging/packages/fceux/-/merge_requests/1
@felixonmars felixonmars merged commit a952a37 into felixonmars:master Nov 12, 2024
1 check passed
@Cryolitia Cryolitia deleted the fceux branch November 12, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants