Back to ESLint and prettier, biome doesn't complain about undefined v…

…ariables (??)

.pre-commit-config.yaml

@@ -23,12 +23,6 @@ repos:
     hooks:
       - id: ruff
       - id: ruff-format
-  - repo: https://github.com/biomejs/pre-commit
-    rev: "v0.4.0"
-    hooks:
-      - id: biome-check
-        additional_dependencies: ["@biomejs/[email protected]"]
-        args: [--unsafe]
   - repo: https://github.com/tox-dev/pyproject-fmt
     rev: 2.2.3
     hooks:
@@ -37,3 +31,18 @@ repos:
     rev: v0.19
     hooks:
       - id: validate-pyproject
+  - repo: local
+    hooks:
+      - id: prettier
+        name: prettier
+        entry: npx [email protected] --no-semi --write
+        language: system
+        types_or: [css, scss]
+        require_serial: true
+      - id: eslint
+        name: eslint
+        entry: yarn eslint content_editor
+        language: system
+        types_or: [javascript]
+        require_serial: true
+        verbose: true

content_editor/static/content_editor/content_editor.css

@@ -32,7 +32,9 @@ html {
   border: 1px solid var(--hairline-color, #e8e8e8);
   border-bottom: none;
   user-select: none;
-  transition: 0.15s background, 0.15s color;
+  transition:
+    0.15s background,
+    0.15s color;
 }
 
 .tabs > .active {
@@ -95,7 +97,9 @@ html {
   padding: 7px;
   margin: 0;
   background-color: var(--darkened-bg, #f8f8f8);
-  transition: 0.15s background, 0.15s color;
+  transition:
+    0.15s background,
+    0.15s color;
 
   white-space: nowrap;
   overflow: hidden;

content_editor/static/content_editor/content_editor.js

@@ -73,14 +73,12 @@
 
     $.extend(window.ContentEditor, JSON.parse(_contentEditorContext))
 
-    ContentEditor.pluginsByPrefix = {}
-    ContentEditor.plugins.forEach((plugin) => {
-      ContentEditor.pluginsByPrefix[plugin.prefix] = plugin
-    })
-    ContentEditor.regionsByKey = {}
-    ContentEditor.regions.forEach((region) => {
-      ContentEditor.regionsByKey[region.key] = region
-    })
+    ContentEditor.pluginsByPrefix = Object.fromEntries(
+      ContentEditor.plugins.map((plugin) => [plugin.prefix, plugin]),
+    )
+    ContentEditor.regionsByKey = Object.fromEntries(
+      ContentEditor.regions.map((region) => [region.key, region]),
+    )
     ContentEditor.hasSections = ContentEditor.plugins.some(
       (plugin) => plugin.sections,
     )
@@ -154,17 +152,9 @@
       .appendTo(orderMachine)
 
     // Pre map plugin regions
-    const pluginRegions = (() => {
-      const result = {}
-      ContentEditor.plugins.forEach((plugin) => {
-        result[plugin.prefix] = plugin.regions
-      })
-      const plugins = ContentEditor.plugins
-      for (let i = 0; i < plugins.length; i++) {
-        result[plugins[i].prefix] = plugins[i].regions
-      }
-      return result
-    })()
+    const pluginRegions = Object.fromEntries(
+      ContentEditor.plugins.map((plugin) => [plugin.prefix, plugin.regions]),
+    )
 
     function shouldInsertAfter(inline, clientY) {
       const rect = inline.getBoundingClientRect()
@@ -219,7 +209,7 @@
         e.dataTransfer.effectAllowed = "move"
         try {
           e.dataTransfer.setData("text/plain", "")
-        } catch (e) {
+        } catch (_e) {
           // IE11 needs this.
         }
 
@@ -228,9 +218,9 @@
       inline.addEventListener("dragend", () => {
         $(".fs-dragging").removeClass("fs-dragging")
         $(".fs-dragover").removeClass("fs-dragover")
-        qsa(".order-machine .inline-related.selected").forEach((el) =>
-          el.classList.remove("selected"),
-        )
+        for (const el of qsa(".order-machine .inline-related.selected")) {
+          el.classList.remove("selected")
+        }
         cancelMouseMonitor()
         cancelMouseMonitor = null
       })
@@ -259,10 +249,10 @@
           )
           const orAfter = shouldInsertAfter(inline, e.clientY)
           toMove.sort((a, b) => (orAfter ? -1 : 1) * (a[1] - b[1]))
-          toMove.forEach((row) => {
+          for (const row of toMove) {
             insertAdjacent(row[0], inline, orAfter)
             row[0].classList.remove("selected")
-          })
+          }
           window.__fs_dragging = null
 
           updateSections()
@@ -424,14 +414,14 @@
 
       let visible = 0
 
-      buttons.forEach((button) => {
+      for (const button of buttons) {
         const plugin = button.dataset.pluginPrefix
         const isVisible =
           pluginInCurrentRegion(plugin) &&
           !/^_unknown_/.test(ContentEditor.currentRegion)
         button.classList.toggle("content-editor-hide", !isVisible)
         visible += isVisible ? 1 : 0
-      })
+      }
 
       if (visible) {
         orderMachineWrapper.removeClass("order-machine-hide-insert-targets")
@@ -754,19 +744,19 @@
       })
       collapseAllInput.attr("checked", LS.get("collapseAll")).trigger("change")
     })()
-    ;(function initializeInsertTargets() {
-      qsa(".order-machine .inline-related").forEach((inline) => {
-        const span = document.createElement("span")
-        span.className = "order-machine-insert-target"
-        inline.appendChild(span)
-      })
-    })()
+
+    /* Initialize targets */
+    for (const inline of qsa(".order-machine .inline-related")) {
+      const span = document.createElement("span")
+      span.className = "order-machine-insert-target"
+      inline.appendChild(span)
+    }
 
     $(document)
-      .on("content-editor:deactivate", (event, row) => {
+      .on("content-editor:deactivate", (_event, row) => {
         row.find("fieldset").addClass("content-editor-invisible")
       })
-      .on("content-editor:activate", (event, row) => {
+      .on("content-editor:activate", (_event, row) => {
         row.find("fieldset").removeClass("content-editor-invisible")
       })
 
@@ -858,17 +848,17 @@
           tabs.eq(0).click()
         }
 
-        qsa(".order-machine .inline-related:not(.empty-form)").forEach(
-          (inline) => {
-            const collapsed = state.collapsed.includes(
-              qs(".field-ordering input", inline).value,
-            )
-            inline.classList.toggle(
-              "collapsed",
-              collapsed && !inline.querySelector(".errorlist"),
-            )
-          },
-        )
+        for (const inline of qsa(
+          ".order-machine .inline-related:not(.empty-form)",
+        )) {
+          const collapsed = state.collapsed.includes(
+            qs(".field-ordering input", inline).value,
+          )
+          inline.classList.toggle(
+            "collapsed",
+            collapsed && !inline.querySelector(".errorlist"),
+          )
+        }
 
         setTimeout(() => {
           window.history.replaceState(null, "", ".")
@@ -885,9 +875,9 @@
     })
     setTimeout(restoreEditorState, 1)
 
-    ContentEditor.plugins.forEach((plugin) => {
+    for (const plugin of ContentEditor.plugins) {
       ContentEditor.addPluginButton(plugin.prefix, plugin.button)
-    })
+    }
 
     const style = document.createElement("style")
     style.textContent = `

eslint.config.mjs

@@ -0,0 +1,14 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+
+
+export default [
+  {files: ["**/*.js"], languageOptions: {sourceType: "script"}},
+  {languageOptions: { globals: globals.browser }},
+  pluginJs.configs.recommended,
+  {
+    rules: {
+      "no-unused-vars": "warn"
+    },
+  },
+];

package.json

@@ -0,0 +1,8 @@
+{
+  "type": "module",
+  "devDependencies": {
+    "@eslint/js": "^9.10.0",
+    "eslint": "^9.10.0",
+    "globals": "^15.9.0"
+  }
+}