Back to biome

.pre-commit-config.yaml

@@ -22,7 +22,14 @@ repos:
     rev: "v0.6.4"
     hooks:
       - id: ruff
+        args: [--unsafe-fixes]
       - id: ruff-format
+  - repo: https://github.com/biomejs/pre-commit
+    rev: "v0.4.0"
+    hooks:
+      - id: biome-check
+        additional_dependencies: ["@biomejs/[email protected]"]
+        args: [--unsafe]
   - repo: https://github.com/tox-dev/pyproject-fmt
     rev: 2.2.3
     hooks:
@@ -31,18 +38,3 @@ repos:
     rev: v0.19
     hooks:
       - id: validate-pyproject
-  - repo: local
-    hooks:
-      - id: prettier
-        name: prettier
-        entry: npx [email protected] --no-semi --write
-        language: system
-        types_or: [css, scss]
-        require_serial: true
-      - id: eslint
-        name: eslint
-        entry: yarn eslint content_editor
-        language: system
-        types_or: [javascript]
-        require_serial: true
-        verbose: true

biome.json

@@ -0,0 +1,57 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
+  "organizeImports": {
+    "enabled": false
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 2
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "a11y": {
+        "noSvgWithoutTitle": "off"
+      },
+      "correctness": {
+        "noUndeclaredVariables": "error",
+        "noUnusedImports": "error",
+        "noUnusedVariables": "error",
+        "useArrayLiterals": "error",
+        "useHookAtTopLevel": "error"
+      },
+      "security": {
+        "noDangerouslySetInnerHtml": "warn"
+      },
+      "style": {
+        "noParameterAssign": "off",
+        "useForOf": "warn"
+      },
+      "suspicious": {
+        "noArrayIndexKey": "warn",
+        "noAssignInExpressions": "off"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "semicolons": "asNeeded"
+    },
+    "globals": ["django", "ContentEditor"]
+  },
+  "css": {
+    "formatter": {
+      "enabled": true
+    },
+    "linter": {
+      "enabled": true
+    }
+  },
+  "json": {
+    "formatter": {
+      "enabled": false
+    }
+  }
+}

content_editor/static/content_editor/content_editor.css

@@ -32,9 +32,7 @@ html {
   border: 1px solid var(--hairline-color, #e8e8e8);
   border-bottom: none;
   user-select: none;
-  transition:
-    0.15s background,
-    0.15s color;
+  transition: 0.15s background, 0.15s color;
 }
 
 .tabs > .active {
@@ -97,9 +95,7 @@ html {
   padding: 7px;
   margin: 0;
   background-color: var(--darkened-bg, #f8f8f8);
-  transition:
-    0.15s background,
-    0.15s color;
+  transition: 0.15s background, 0.15s color;
 
   white-space: nowrap;
   overflow: hidden;

content_editor/static/content_editor/content_editor.js

@@ -40,9 +40,7 @@
       regionsByKey: Object.fromEntries(
         ContentEditor.regions.map((region) => [region.key, region]),
       ),
-      hasSections: ContentEditor.plugins.some(
-        (plugin) => plugin.sections,
-      ),
+      hasSections: ContentEditor.plugins.some((plugin) => plugin.sections),
     })
   }
 
@@ -248,7 +246,7 @@
       inline.addEventListener("drop", (e) => {
         if (window.__fs_dragging) {
           e.preventDefault()
-          for (let inline of qsa(".order-machine .inline-related.selected")) {
+          for (const inline of qsa(".order-machine .inline-related.selected")) {
             selectSection(inline)
           }
 
@@ -319,7 +317,10 @@
         div.style.right = "5px"
         div.style.height = `${until.top - from.top + until.height + 10}px`
 
-        div.classList.toggle("content-editor-hide", fromInline.classList.contains("collapsed"))
+        div.classList.toggle(
+          "content-editor-hide",
+          fromInline.classList.contains("collapsed"),
+        )
       }
 
       for (const inline of inlines) {
@@ -719,7 +720,7 @@
       }
     })
 
-    $(document).on("formset:removed", (event, $row, formsetName) => {
+    $(document).on("formset:removed", (event, _$row, formsetName) => {
       if (event.detail?.formsetName) {
         // Django >= 4.1
         handleFormsetRemoved(event.detail.formsetName)
@@ -738,9 +739,9 @@
     }
 
     function hideSection(inline, hide = true) {
-      const children = childrenMap && childrenMap.get(inline)
+      const children = childrenMap?.get(inline)
       if (children) {
-        for (let child of children) {
+        for (const child of children) {
           child.classList.toggle("content-editor-hide", hide)
           if (hide || !child.classList.contains("collapsed")) {
             /* Hiding is recursive, showing uncollapsed child sections too */
@@ -751,15 +752,14 @@
     }
 
     function selectSection(inline) {
-      const children = childrenMap && childrenMap.get(inline)
+      const children = childrenMap?.get(inline)
       if (children) {
-        for (let child of children) {
+        for (const child of children) {
           child.classList.add("selected")
           selectSection(child)
         }
       }
     }
-
     // Initialize tabs and currentRegion.
     ;(() => {
       const tabContainer = $(".tabs.regions")
@@ -790,7 +790,9 @@
     function initializeCollapseAll() {
       const collapseAllInput = $(".collapse-items input")
       collapseAllInput.on("change", function () {
-        for (const inline of qsa(".order-machine .inline-related:not(.empty-form)")) {
+        for (const inline of qsa(
+          ".order-machine .inline-related:not(.empty-form)",
+        )) {
           collapseInline(inline, this.checked)
         }
         LS.set("collapseAll", this.checked)
@@ -891,7 +893,7 @@
         scrollY: window.scrollY,
         collapsed: qsa(
           ".order-machine .inline-related.collapsed:not(.empty-form) .field-ordering input",
-        ).map((input) => input.value)
+        ).map((input) => input.value),
       })
     }