FairGBM refactor (multi-threading etc.) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreFCruz
force-pushed
the
fairgbm-multithreading
branch
from
cbf19a1 to
3c30821
Compare
AlbertoEAF
reviewed
Jul 5, 2022
AndreFCruz
force-pushed
the
fairgbm-multithreading
branch
from
f2d8ab2 to
bccc70e
Compare
This was referenced Jul 20, 2022
AndreFCruz
changed the title
AndreFCruz
commented
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
TODO: as per the profiling we ran, the first thing to optimize is all the string comparisons happening in the CosntrainedObjectiveFunction -- these take up around 1/3rd of the total run time.
Must only be merged after #15 and #16
TODO: needs a rebase a-la #16