Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Remove git connector #390

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove git connector #390

wants to merge 4 commits into from

Conversation

cverna
Copy link
Contributor

@cverna cverna commented Jul 18, 2018

This PR replaces the git connector by a pagure connector for fedora-packages to fetch the spec file sources.

Fixes #329

Copy link
Member

@pypingou pypingou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine to me, but this means we're loosing the links to patches (which is also interesting for example for packagers in other communities). Should we add something in the UI saying that they can find more information at ?


def get_spec(self):
resp = requests.get(
'https://src.fedoraproject.org/rpms/{pkg}/raw/{branch}/f/{pkg}.spec'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a configuration as stg won't be able to reach prod (for example) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yes this should be in a configuration file

@cverna
Copy link
Contributor Author

cverna commented Jul 18, 2018

Overall looks fine to me, but this means we're loosing the links to patches (which is also interesting for example for packagers in other communities). Should we add something in the UI saying that they can find more information at ?

Yes I ll look at what can be done in the UI ( maybe adding a link to the git repo)

@abitrolly
Copy link
Contributor

Indexing and checking for patches is a good idea. Does Fedora maintain a DB of parsed .spec files that is ready to be queried? I believe https://wiki.debian.org/UltimateDebianDatabase/ is a Debian approach to do this, but for me it is better to have this separated over several distributed services. Blockchain? :)

This commit replace the connector that accessed
a git repository in order to get a spec file
by a http call to src.fp.o.

Signed-off-by: Clement Verna <[email protected]>
Signed-off-by: Clement Verna <[email protected]>
Signed-off-by: Clement Verna <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants