-
Notifications
You must be signed in to change notification settings - Fork 59
Remove git connector #390
base: master
Are you sure you want to change the base?
Remove git connector #390
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine to me, but this means we're loosing the links to patches (which is also interesting for example for packagers in other communities). Should we add something in the UI saying that they can find more information at ?
|
||
def get_spec(self): | ||
resp = requests.get( | ||
'https://src.fedoraproject.org/rpms/{pkg}/raw/{branch}/f/{pkg}.spec' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a configuration as stg won't be able to reach prod (for example) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, yes this should be in a configuration file
Yes I ll look at what can be done in the UI ( maybe adding a link to the git repo) |
Indexing and checking for patches is a good idea. Does Fedora maintain a DB of parsed .spec files that is ready to be queried? I believe https://wiki.debian.org/UltimateDebianDatabase/ is a Debian approach to do this, but for me it is better to have this separated over several distributed services. Blockchain? :) |
This commit replace the connector that accessed a git repository in order to get a spec file by a http call to src.fp.o. Signed-off-by: Clement Verna <[email protected]>
Signed-off-by: Clement Verna <[email protected]>
Signed-off-by: Clement Verna <[email protected]>
Signed-off-by: Clement Verna <[email protected]>
This PR replaces the git connector by a pagure connector for fedora-packages to fetch the spec file sources.
Fixes #329