Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter by case citations in /legal/search/ #5165

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

fec-jli
Copy link
Contributor

@fec-jli fec-jli commented Jun 2, 2022

Summary

In order to create the legal web search app, we need add filter by citations(statutory citation and (regulatory_citation) in MUR's search. This PR will add general filter by case_citations which used for 3 case types: murs, admin_fines and adrs(not release yet)

  • Endpoint url: /legal/search/?type=murs&case_statutory_citation=xxxxx&case_regulatory_citation=yyyyy
  • Three Parameters:
    case_statutory_citation,
    case_regulatory_citation,
    case_citation_require_all

mur_citation

Completion criteria

  • Create filter by case_citations
  • Recreate ES index("docs") and reload whole data
  • Create follow-up ticket to reload ES data on stage and prod spaces
  • Sync with team

Required reviewers

2 developers

Impacted areas of the application

legal search

How to test

(It is better test locally first)

python manage.py load_current_murs -s 7958
python manage.py load_current_murs -s 7949
python manage.py load_current_murs -s 7927
python manage.py load_current_murs -s 7926
python manage.py load_current_murs -s 7923
python manage.py load_current_murs -s 7212
python manage.py load_current_murs -s 4633 
python manage.py load_current_murs -s 3987

http://127.0.0.1:5000/v1/legal/search/?type=murs&case_statutory_citation=52 U.S.C. §30116&case_statutory_citation=52 U.S.C. §30122&case_regulatory_citation=11 CFR §110.4&case_citation_require_all=True

http://127.0.0.1:5000/v1/legal/search/?type=murs&case_statutory_citation=52 U.S.C. §30104&case_regulatory_citation=11 CFR §116.10&case_citation_require_all=True

@fec-jli fec-jli requested review from pkfec, hcaofec and cnlucas June 2, 2022 03:49
@fec-jli fec-jli changed the title [WIP]Add filter by citations in /legal/search/ Add filter by citations in /legal/search/ Jun 8, 2022
@fec-jli
Copy link
Contributor Author

fec-jli commented Jun 11, 2022

@fec-jli fec-jli changed the title Add filter by citations in /legal/search/ Add filter by case citations in /legal/search/ Jun 13, 2022
Copy link
Contributor

@pkfec pkfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested new filters on my local and also on dev space. New filters work as expected.
Awesome work @fec-jli.

Copy link
Member

@cnlucas cnlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you so much for pairing with me on review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MURs: Prototype using Elasticsearch DSL to filter by citations
3 participants