Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6570 - Icons and meta data #6571

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Nov 27, 2024

Summary

(Include a summary of proposed changes and connect issue below)

Required reviewers

  • 1 front-end?
  • 1 design/UX?

Impacted areas of the application

Meta data site-wide and various social sharing images and thumbnails:

  • New devices and resolutions = new image sizes and dropping older image sizes
  • New iOS: renaming 'apple-touch-icon-precomposed' (now many years abandoned) to the more standard apple-touch-icon
  • Dropped outdated Internet Explorer tags
  • Dropped outdated HandheldFriendly and MobileOptimized meta data tags (used for very old versions of BlackBerry and Windows Mobile devices)
  • For the /general/favicons-*.png, updating to "FEC.gov" instead of "The new FEC.gov" since the site's been standard for more than five years
  • Removed the "This site is in beta" message from the top of the header/seal image that only appears when printing pages
  • Added a white background to the smallest favicon since dark mode is a thing across devices
  • Removed START_YEAR and END_YEAR window vars since the front-end isn't referencing them inside JavaScript

Screenshots

The new images are in Files Changed but otherwise won't show up until this is merged, deployed, and crawled again

Related PRs

There's another issue/PR for the canonical tag so we aren't touching those here.

How to test

  • Pull the branch
  • npm run build
  • Find someplace JavaScript is using START_YEAR?
  • Find someplace JavaScript is using END_YEAR?
  • Find someplace JavaScript is using TRANSITION_URL?
  • Review the image changes shown here i.e. the ones added and removed listed under Files Changed
  • For
    • Homepage
    • About
    • H4CC page(s)
    • Some data pages
    • Some legal pages
  • Check
    • That the source code's <link rel="icon" href values are accurate
    • That the source code's <link rel="apple-touch-icon" href values are accurate

@rfultz rfultz added this to the 26.i milestone Nov 27, 2024
@rfultz rfultz self-assigned this Nov 27, 2024
@rfultz rfultz marked this pull request as ready for review November 27, 2024 13:47
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.91%. Comparing base (8a7a79d) to head (709aea2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6571   +/-   ##
========================================
  Coverage    79.91%   79.91%           
========================================
  Files          235      235           
  Lines         5147     5147           
========================================
  Hits          4113     4113           
  Misses        1034     1034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rfultz rfultz modified the milestones: 26.i, 27.1 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 Ready
Development

Successfully merging this pull request may close these issues.

Update meta tags and sharing images
1 participant