-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass Deprecation Warnings #6422
Open
rfultz
wants to merge
14
commits into
develop
Choose a base branch
from
feature/6387-sass-deprecation-warnings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6422 +/- ##
========================================
Coverage 79.91% 79.91%
========================================
Files 235 235
Lines 5147 5147
========================================
Hits 4113 4113
Misses 1034 1034 ☔ View full report in Codecov by Sentry. |
johnnyporkchops
requested review from
johnnyporkchops
and removed request for
johnnyporkchops
August 14, 2024 19:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing Sass deprecation and, while adjusting everything, added some Sass formatting
Required reviewers
Impacted areas of the application
The entire front-end, but most changes came hit mixins and seemed to mostly fall on
Screenshots
Should be zero visual changes
No longer getting screen after screen of deprecation warnings!
Related PRs
None
How to test
npm i
npm run build
./manage.py runserver