Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass Deprecation Warnings #6422

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

rfultz
Copy link
Contributor

@rfultz rfultz commented Aug 8, 2024

Summary

Addressing Sass deprecation and, while adjusting everything, added some Sass formatting

Required reviewers

  • front-end
  • anyone who'd like to scour for visual changes

Impacted areas of the application

The entire front-end, but most changes came hit mixins and seemed to mostly fall on

  • column widths and offsets (like 2 columns, -1)
  • icons, especially on buttons
  • this is not a complete list—there were nearly 200 files changed

Screenshots

Should be zero visual changes

No longer getting screen after screen of deprecation warnings!

image

Related PRs

None

How to test

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.91%. Comparing base (8a7a79d) to head (3dc303c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6422   +/-   ##
========================================
  Coverage    79.91%   79.91%           
========================================
  Files          235      235           
  Lines         5147     5147           
========================================
  Hits          4113     4113           
  Misses        1034     1034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnnyporkchops johnnyporkchops requested review from johnnyporkchops and removed request for johnnyporkchops August 14, 2024 19:59
@patphongs patphongs modified the milestones: 25.i, 26.3 Sep 11, 2024
@rfultz rfultz requested a review from patphongs November 20, 2024 18:39
@rfultz rfultz mentioned this pull request Dec 10, 2024
4 tasks
@rfultz rfultz modified the milestones: 26.3, 27.1 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 Ready
Development

Successfully merging this pull request may close these issues.

Sass Stylesheet Deprecation Warnings
3 participants