[MERGE BEFORE 09/28/23 RELEASE] Add link to document page #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfultz
reviewed
Sep 28, 2023
| </header> | ||
| <p class="t-sans t-normal"> |
There was a problem hiding this comment.
The <p> and <i> will always be included, right? Even if there's no self.file_url, no self.extension, and/or no self.size?
Comment on lines
+30
to
+31
| {% if self.extension %} | ({{ self.extension }}){% endif %} | ||
| {% if self.size %} | ({{ self.size }}){% endif %} |
There was a problem hiding this comment.
These could be included even if there's no self.file_url, right? Granted, it seems unlikely
Codecov Report
@@ Coverage Diff @@
## release/public-20230926 #5931 +/- ##
===========================================================
- Coverage 78.16% 78.14% -0.02%
===========================================================
Files 286 286
Lines 9167 9167
Branches 653 653
===========================================================
- Hits 7165 7164 -1
- Misses 2002 2003 +1 |
rfultz
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
DocumentPages, otherwise not navigable on the site, are showing in search results. This is a temporary fix so users will be able to get to the document if they access a DocumentPage through a search result link. A final solution for handling this issue is being researchd. See this comment/mockup in issueRequired reviewers
one frontend
Impacted areas of the application
Document pages in Reports about the FEC
Screenshots
Related PRs
Related PRs against other branches:
There is a WIP/DRAFT PR that shows more options for the final solution #5922
How to test
Pages > Home > About > Reports about the FEC, then go into one of the sections likeAgency Operations or FOiA