Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N/A for schedule A datatable not filtering correctly from canonical page #5220

Open
1 task
patphongs opened this issue May 12, 2022 · 1 comment · May be fixed by #5347
Open
1 task

N/A for schedule A datatable not filtering correctly from canonical page #5220

patphongs opened this issue May 12, 2022 · 1 comment · May be fixed by #5347
Assignees
@johnnyporkchops
Labels
Bug Pipeline: PI Backlog Work: Front-end

Comments

@patphongs
Copy link
Member

patphongs commented May 12, 2022 •
edited by cnlucas
Loading

Summary

What we're after:
When trying to click on the individual contributions datatable link from a committee canonical page, it does not correctly filter the value of N/A. It appears to strip out the / and interprets it as strictly NA.

https://www.fec.gov/data/committee/C00213512/?tab=raising#section-3

Screen Shot 2022-05-12 at 1 28 09 PM

Completion criteria

  • When clicking on the individual contributions datatable links N/A values are correctly filtered
@cnlucas cnlucas added this to the Sprint 18.6 milestone Jul 7, 2022
@johnnyporkchops johnnyporkchops linked a pull request Jul 25, 2022 that will close this issue
Open
@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Sep 2, 2022 •
edited
Loading

@patphongs , A URL with N/A will always be changed to N%2FA by the browser. So whether we put N/A in a link to filtered datatable or a user puts N/A in the employer field on a datatable, the API call will always turn it into N%2FA. The filter tags and the checkbox select may show N/A verbatim, but it is always calling N%2FA which does not return only contributors who submitted N/A, verbatim.

Screen Shot 2022-09-01 at 8 14 47 PM

Screen Shot 2022-09-01 at 8 14 33 PM

@cnlucas cnlucas modified the milestones: Sprint 19.2, Sprint 19.4 Sep 29, 2022
@pkfec pkfec modified the milestones: Sprint 19.4, Sprint 19.5 Oct 18, 2022
@dorothyyeager dorothyyeager modified the milestones: Sprint 19.5, Sprint 19.6 Nov 9, 2022
@patphongs patphongs moved this to PI backlog in Website project Feb 23, 2024
This was referenced Apr 24, 2024
Merged
Closed
@fec-jli fec-jli mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnnyporkchops johnnyporkchops

Labels
Bug Pipeline: PI Backlog Work: Front-end
Projects
Website project
Status: 🗄️ PI backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP Do Not Merge] N/A cannot be built into URL for filtering Datatables fecgov/fec-cms
8 participants
@johnnyporkchops @pkfec @patphongs @dorothyyeager @rfultz @JonellaCulmer @djgarr @cnlucas