Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix N/A search for Schedule-a and Schedule-b #5812

Closed
1 task
fec-jli opened this issue Apr 29, 2024 · 0 comments · Fixed by #5824
Closed
1 task

Fix N/A search for Schedule-a and Schedule-b #5812

fec-jli opened this issue Apr 29, 2024 · 0 comments · Fixed by #5824
Assignees
Milestone

Comments

@fec-jli
Copy link
Contributor

fec-jli commented Apr 29, 2024

What we’re after

When we search for contributor_occupation and contributor_employer on all receipts page, filter by 'N/A',
return a lot of wrong result that most of contributor_occupation value are not equal 'N/A'

When we search for disbursement_description on all disbursements page, filter by 'N/A',
return a lot of wrong result that most of disbursement_description value are not equal 'N/A'

Ex1: contributor_occupation=N/A, return about 2,805,000 rows for '/schedules/schedule_a/'
https://www.fec.gov/data/receipts/?data_type=processed&contributor_occupation=N%2FA&two_year_transaction_period=2024&min_date=01%2F01%2F2023&max_date=12%2F31%2F2024

Ex2: contributor_employer=N/A, return about 1,534,000 rows for '/schedules/schedule_a/'
https://www.fec.gov/data/receipts/?data_type=processed&contributor_employer=N%2FA&two_year_transaction_period=2024&min_date=01%2F01%2F2023&max_date=12%2F31%2F2024

Ex3: disbursement_description=N/A, return about 50,781 rows for '/schedules/schedule_b/'
https://www.fec.gov/data/disbursements/?data_type=processed&two_year_transaction_period=2024&min_date=01%2F01%2F2023&max_date=12%2F31%2F2024&disbursement_description=N%2FA

This PR will fix filter by 'N/A' for '/schedules/schedule_a/' and '/schedules/schedule_b/' endpoints.

Related cms ticket(s)

fecgov/fec-cms#5220

Action item(s)

  • Fix filter by 'N/A/', return correct result

References

PR: #5809

@fec-jli fec-jli self-assigned this Apr 29, 2024
@fec-jli fec-jli added this to the 24.i milestone Apr 29, 2024
@cnlucas cnlucas changed the title Fix N/A search for Schedula-a and Schedula-b Fix N/A search for Schedule-a and Schedule-b Apr 30, 2024
@pkfec pkfec moved this to 📥 Assigned in Website project May 9, 2024
@fec-jli fec-jli moved this from 📥 Assigned to 👀 Ready in Website project May 14, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready to ✅ Done in Website project May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant