Fix path alias resolution (#126)

feature-sliced · Nov 17, 2024 · 9c1fec9 · 9c1fec9
1 parent bfc5475
commit 9c1fec9
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 2 deletions.
diff --git a/.changeset/green-flies-exercise.md b/.changeset/green-flies-exercise.md
@@ -0,0 +1,5 @@
+---
+'@feature-sliced/steiger-plugin': patch
+---
+
+Fix path alias resolution when baseUrl is present in tsconfig
diff --git a/packages/steiger-plugin-fsd/src/_lib/collect-related-ts-configs.ts b/packages/steiger-plugin-fsd/src/_lib/collect-related-ts-configs.ts
@@ -107,16 +107,21 @@ function makeRelativePathAliasesAbsolute(
   firstConfigWithPaths: CollectRelatedTsConfigsPayload,
 ) {
   const { tsconfig: mergedConfig } = finalConfig
+  const {
+    compilerOptions: { paths, baseUrl },
+  } = mergedConfig
   const absolutePaths: Record<string, Array<string>> = {}
 
   if (!firstConfigWithPaths.tsconfigFile) {
     return mergedConfig.compilerOptions.paths
   }
 
-  for (const entries of Object.entries(mergedConfig.compilerOptions.paths)) {
+  for (const entries of Object.entries(paths)) {
     const [key, paths] = entries as [key: string, paths: Array<string>]
     absolutePaths[key] = paths.map((relativePath: string) =>
-      resolve(dirname(firstConfigWithPaths.tsconfigFile!), relativePath),
+      baseUrl
+        ? resolve(dirname(firstConfigWithPaths.tsconfigFile!), baseUrl, relativePath)
+        : resolve(dirname(firstConfigWithPaths.tsconfigFile!), relativePath),
     )
   }
 
@@ -245,4 +250,45 @@ if (import.meta.vitest) {
 
     expect(collectRelatedTsConfigs(payload)).toEqual(expectedResult)
   })
+
+  test('correctly resolves paths if baseUrl is set', () => {
+    const payload: CollectRelatedTsConfigsPayload = {
+      tsconfigFile: resolve(joinFromRoot('user', 'projects', 'project-0', 'tsconfig.json')),
+      tsconfig: {
+        compilerOptions: {
+          baseUrl: './src',
+          paths: {
+            '~': ['./'],
+            '~/*': ['./*'],
+          },
+          strict: true,
+          noUncheckedIndexedAccess: false,
+          forceConsistentCasingInFileNames: true,
+          noImplicitOverride: true,
+          module: 'ESNext',
+          noEmit: true,
+        },
+      },
+    }
+
+    const expectedResult = [
+      {
+        compilerOptions: {
+          baseUrl: './src',
+          paths: {
+            '~': [resolve(joinFromRoot('user', 'projects', 'project-0', 'src'))],
+            '~/*': [resolve(joinFromRoot('user', 'projects', 'project-0', 'src', '*'))],
+          },
+          strict: true,
+          noUncheckedIndexedAccess: false,
+          forceConsistentCasingInFileNames: true,
+          noImplicitOverride: true,
+          module: 'ESNext',
+          noEmit: true,
+        },
+      },
+    ]
+
+    expect(collectRelatedTsConfigs(payload)).toEqual(expectedResult)
+  })
 }