Skip to content

Commit

Permalink
.
Browse files Browse the repository at this point in the history
  • Loading branch information
illright committed Nov 12, 2024
1 parent eeed792 commit 0a7f7a4
Show file tree
Hide file tree
Showing 4 changed files with 156 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/quality.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ jobs:
continue-on-error: true

- name: Compare output
run: diff <(jq --sort-keys . output.json) <(jq --sort-keys . examples/kitchen-sink-of-fsd-issues/reference-output.json)
run: diff <(jq --sort-keys . output.json) <(jq --sort-keys . examples/kitchen-sink-of-fsd-issues/reference-output-${{ matrix.os }}.json)
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
"message": "Forbidden import from higher layer \"app\".",
"location": {
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/api/getUser.ts"
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/api/getUser.ts"
},
"ruleName": "fsd/forbidden-imports",
"severity": "error"
Expand All @@ -12,60 +12,60 @@
"fixes": [
{
"type": "rename",
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user",
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user",
"newName": "users"
}
],
"location": {
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/entities"
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities"
},
"ruleName": "fsd/inconsistent-naming",
"severity": "error"
},
{
"message": "This slice has no references. Consider removing it.",
"location": {
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/users"
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/users"
},
"ruleName": "fsd/insignificant-slice",
"severity": "error"
},
{
"message": "This slice has no references. Consider removing it.",
"location": {
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user"
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user"
},
"ruleName": "fsd/insignificant-slice",
"severity": "error"
},
{
"message": "Forbidden sidestep of public API when importing from \"@/app/ui/App\".",
"location": {
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/api/getUser.ts"
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/api/getUser.ts"
},
"ruleName": "fsd/no-public-api-sidestep",
"severity": "error"
},
{
"message": "Having a folder with the name \"api\" inside a segment could be confusing because that name is commonly used for segments. Consider renaming it.",
"location": {
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/ui/api"
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/ui/api"
},
"ruleName": "fsd/no-reserved-folder-names",
"severity": "error"
},
{
"message": "Layer \"app\" should not have \"ui\" segment.",
"location": {
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/app/ui"
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/app/ui"
},
"ruleName": "fsd/no-ui-in-app",
"severity": "error"
},
{
"message": "Layer \"processes\" is deprecated, avoid using it",
"location": {
"path": "/home/runner/work/steiger/examples/kitchen-sink-of-fsd-issues/src/processes"
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/processes"
},
"ruleName": "fsd/no-processes",
"severity": "error"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
[
{
"message": "Forbidden import from higher layer \"app\".",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/api/getUser.ts"
},
"ruleName": "fsd/forbidden-imports",
"severity": "error"
},
{
"message": "Inconsistent pluralization of slice names. Prefer all plural names",
"fixes": [
{
"type": "rename",
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user",
"newName": "users"
}
],
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities"
},
"ruleName": "fsd/inconsistent-naming",
"severity": "error"
},
{
"message": "This slice has no references. Consider removing it.",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/users"
},
"ruleName": "fsd/insignificant-slice",
"severity": "error"
},
{
"message": "This slice has no references. Consider removing it.",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user"
},
"ruleName": "fsd/insignificant-slice",
"severity": "error"
},
{
"message": "Forbidden sidestep of public API when importing from \"@/app/ui/App\".",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/api/getUser.ts"
},
"ruleName": "fsd/no-public-api-sidestep",
"severity": "error"
},
{
"message": "Having a folder with the name \"api\" inside a segment could be confusing because that name is commonly used for segments. Consider renaming it.",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/ui/api"
},
"ruleName": "fsd/no-reserved-folder-names",
"severity": "error"
},
{
"message": "Layer \"app\" should not have \"ui\" segment.",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/app/ui"
},
"ruleName": "fsd/no-ui-in-app",
"severity": "error"
},
{
"message": "Layer \"processes\" is deprecated, avoid using it",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/processes"
},
"ruleName": "fsd/no-processes",
"severity": "error"
}
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
[
{
"message": "Forbidden import from higher layer \"app\".",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/api/getUser.ts"
},
"ruleName": "fsd/forbidden-imports",
"severity": "error"
},
{
"message": "Inconsistent pluralization of slice names. Prefer all plural names",
"fixes": [
{
"type": "rename",
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user",
"newName": "users"
}
],
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities"
},
"ruleName": "fsd/inconsistent-naming",
"severity": "error"
},
{
"message": "This slice has no references. Consider removing it.",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/users"
},
"ruleName": "fsd/insignificant-slice",
"severity": "error"
},
{
"message": "This slice has no references. Consider removing it.",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user"
},
"ruleName": "fsd/insignificant-slice",
"severity": "error"
},
{
"message": "Forbidden sidestep of public API when importing from \"@/app/ui/App\".",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/api/getUser.ts"
},
"ruleName": "fsd/no-public-api-sidestep",
"severity": "error"
},
{
"message": "Having a folder with the name \"api\" inside a segment could be confusing because that name is commonly used for segments. Consider renaming it.",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/entities/user/ui/api"
},
"ruleName": "fsd/no-reserved-folder-names",
"severity": "error"
},
{
"message": "Layer \"app\" should not have \"ui\" segment.",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/app/ui"
},
"ruleName": "fsd/no-ui-in-app",
"severity": "error"
},
{
"message": "Layer \"processes\" is deprecated, avoid using it",
"location": {
"path": "/home/runner/work/steiger/steiger/examples/kitchen-sink-of-fsd-issues/src/processes"
},
"ruleName": "fsd/no-processes",
"severity": "error"
}
]

0 comments on commit 0a7f7a4

Please sign in to comment.