Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dove before after around utils #705

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

fratzinger
Copy link
Collaborator

Use regular hooks in around with beforeAround & afterAround:

import { beforeAround } from 'feathers-hooks-common';

service.hooks({
  around: {
    find: [
      beforeAround((context) => {
        // do whatever you need to do
      }),
      // other around hooks
    ]
  }
});

fratzinger and others added 9 commits September 27, 2022 21:23
* Updated @feathersjs dependencies to ^5.0.0-pre.3

* Added @feathersjs/adapter-commons to import `Paginated`

* Updated Typescript to 4.2.4

* Set minimum Typescript to 4.0 for dslint

* Re-import Paginated

* Updated `combine` to work with Dove

Re-implemented `processHooks` inside, since that’s all it was calling.

* Updated dslint tests - all project tests passing

Changed `feathers` import
Added required properties for `HookContext`
Updated typeexpectations for dslint since `Hook` is now an alias

* Updated @feathersjs dependencies to ^5.0.0-pre.4

* Re-import Paginated

* Removed @feathersjs/adapter-commons from dependencies

* Updated @feathersjs dependencies to ^5.0.0-pre.9

All tests passing

* refactor!: move to feathers v5

* chore: update package-lock

* fix: use generics for hooks
- @see docs link
- correct utils docs link
- export * from
- move types to individual files
- use prettier

* refactor: move to generic HookContext

* refactor: make tests run again

* refactor: pass tests

* chore: add prettier

Co-authored-by: Jesse Cox <[email protected]>
Base automatically changed from dove to master February 24, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant