ci: Extend python base version for test cases #3929
Conversation
sudohainguyen
changed the title
sudohainguyen
changed the title
sudohainguyen
force-pushed
the
ci
branch
4 times, most recently
from
1e329f3
to
da33350
Compare
sudohainguyen
changed the title
|
Running integration tests only for 3.10 sounds a bit too risky unless we explicitly drop support for lower versions. I think all tests should include the lowest supported python version (3.8 currently, but if we in fact drop it then 3.9) |
actually we still do have full integration tests across 3 python versions on master only (after merged), however I agree that we should extend, not replace for now |
Signed-off-by: Hai Nguyen <[email protected]>
| @@ -86,7 +86,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: [ "3.8" ] | |||
| python-version: [ "3.8", "3.10" ] | |||
There was a problem hiding this comment.
this purely adds 3.10 support
| @@ -12,8 +12,6 @@ jobs: | |||
| exclude: | |||
| - os: macOS-latest | |||
| python-version: "3.9" | |||
| - os: macOS-latest | |||
| python-version: "3.10" | |||
There was a problem hiding this comment.
did you mean to drop 3.10 here?
There was a problem hiding this comment.
Drop from exclude list, which means we will conduct py310 unit test on macos
There was a problem hiding this comment.
oh i missed the exclude key. Nice.
Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: tokoko <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
What this PR does / why we need it:
Following up with NEP and many libraries are dropping py38 support
We need to migrate our CI integration tests to py39+ version
Additional information:
Related to #3928, if we want to run integration tests with pandas v2, we must run on py3.9+,
So that we need to extend our integration tests workflow matrix to run on py310 additionally
Which issue(s) this PR fixes:
Fixes #