-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Synapse Launcher #61
base: master
Are you sure you want to change the base?
Conversation
Add Synapse Launcher (with corresponding python dependency and required changes in different files)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xiaoyongzhu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @xiaoyongzhu. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Remove unnecessary printout
still use service principal
Change the authentication chain (first using Environmental variables then using device login)
@xiaoyongzhu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add Synapse Launcher (with corresponding python dependency and required changes in different files)
What this PR does / why we need it:
To add a launcher support for Synapse
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Yes