Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-tool): call the 'fdo-owner-tool' with the correct arguments #564

Merged

Conversation

mmartinv
Copy link
Contributor

@mmartinv mmartinv commented Oct 18, 2023

Fix the fdo-admin-tool aio device manufacture command which fails
when running the fdo-owner-tool dump-device-credential command
after the manufacturing process has finished successfully.

Closes #563

Signed-off-by: Miguel Martín [email protected]

@nullr0ute
Copy link
Contributor

Could probably do with a slightly more detailed commit log

@mmartinv mmartinv force-pushed the fix-admin-tool-print-device-credentials branch from c611dd1 to d524ef9 Compare October 19, 2023 13:22
@mmartinv mmartinv requested a review from a team October 23, 2023 05:36
Fix the `fdo-admin-tool aio device manufacture` command which fails
when running the `fdo-owner-tool dump-device-credential` command
after the manufacturing process has finished successfully.

Closes fdo-rs#563

Signed-off-by: Miguel Martín <[email protected]>
@mmartinv mmartinv force-pushed the fix-admin-tool-print-device-credentials branch from d524ef9 to b15b887 Compare November 13, 2023 23:03
Copy link
Contributor

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; .arg is for a single argument, .args handles multiple arguments

@mergify mergify bot merged commit 913490d into fdo-rs:main Nov 21, 2023
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The admin tool fails to print the device credentials after the device manufacturing has been completed.
4 participants